Skip to content
Snippets Groups Projects
Commit 56cd9b79 authored by Patrick Williams's avatar Patrick Williams Committed by Android Build Coastguard Worker
Browse files

Improve updateInputFlinger performance

This change improves the performance of the WindowInfosListenerInvoker work done on SurfaceFlinger's background executor thread. The primary optimization made is not sending a WindowInfosReportedListener with every call to WindowInfosListener.onWindowInfosChanged. Instead, we send a new interface, WindowInfosPublisher, and a unique listener id to listeners when they're added.  Listeners call WindowInfosPublisher.ackWindowInfosReceived with their id after processing each update.

From traces taken during development, the new code is a major improvement, taking about 15% of the time spent previously on SurfaceFlinger's background thread for sending window infos. Performance with this change seems roughly in line with the performance in T.

Bug: 290377931
Test: atest WindowInfosListenerTest
Test: atest WindowInfosListenerInvokerTest
Test: manually killing system server and checking valid state on restart
(cherry picked from commit acd2258a)
(cherry picked from commit e8a7ab25)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:82f3463d449eb13e28c5dbffeee16e10721c71d2)
Merged-In: Ib39ba935727df0bc1ab4030bcfe8301de7e64805
Change-Id: Ib39ba935727df0bc1ab4030bcfe8301de7e64805
parent a0faf61f
No related branches found
No related tags found
No related merge requests found
Showing
with 332 additions and 242 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment