Ramakant Singh authored 4 years ago and Simão Gomes Viana committed 5 months ago

1. SurfaceFlinger: Fix virtual display related issues. 1) Validate
output
buffer usage bit appropriately Validate output buffer usage bit only
against GRALLOC_USAGE_HW_COMPOSER to differentiate GLES only
conposition
and HWC/MIXED composition. 2) Exclude video encoder usage for
scratch
buffer Sink and Scratch buffers in VDS are using same usage
flags. This
causes video encoder flag to be set for scratch buffers
Also. Exclude
video encoder flag from scratch buffer usage flags as
scratch buffers
are used only as write back input and not video
encoder input.

2. sf: Allow VDS to use HWC -- Preserve VDS layer
pixel format based on
GRALLOC flags. -- skip color layer for vds

3. sf: Add secure content support for VDS

4. sf: Enable GPU comp. for non-primary displays
Ensure that "Return
status" of dequeueBuffer() complies with API
	requirements. Client relies
on this status to call requestBuffer()
	upon reallocation.

5. sf: Enable UBWC on virtual display scratch buffer Set
	GRALLOC_USAGE_HW_FB usage flag on virtual display Scratch
	buffer to
	enable UBWC.

Change-Id: Ia49a175372ca187a295531e18f8e84dc22a19486
CRs-Fixed: 2656027
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Kevin F. Haggerty authored 3 years ago and Simão Gomes Viana committed 5 months ago

* Change I7f4174581e24e361577640b9263514a168ed482d implemented
  validation of the buffer description info prior to creating
  the descriptor. Some of our legacy devices need to whitelist
  additional usage bits to support various functionality.

libui: Extend adb95ae to Gralloc3
libui: Extend adb95ae to Gralloc4

This commit squashes:
  libui: Convert lineage product variables to soong config variables
  Change-Id: Ib687c966d4eafcc1128611b95ebed00fd0a8bfaf

Change-Id: Ie369e78f78e9ac0b18ab3dfea520d4f123005d92
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Vinay Verma authored 6 years ago and Simão Gomes Viana committed 5 months ago

libstagefright_omx library need to be extended to vendor which
is depenednet on libgui which is a vndk_private lib.
Creating vendor version so that libstagefright_omx_ext can link
to libgui_vendor.

CRs-Fixed: 2258968
Change-Id: I777eebffc405c8bb74aab270e9f272c806501458
Signed-off-by: Volodymyr Zhdanov <wight554@gmail.com>
Signed-off-by: SamarV-121 <samarvispute121@pm.me>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Simao Gomes Viana authored 5 years ago and Simão Gomes Viana committed 5 months ago

Change-Id: Icdfd3512a79d9935d3fdb611c96dc8fd91a5e1c5
Signed-off-by: DennySPB <dennyspb@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Simao Gomes Viana <simao@halogenos.org>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Change-Id: Iaacc63e7a24129abec9b177624c86cd722aba8c8

Remove the flag for the fix in commit 4a719e88 so it will be enabled on 24Q3 release.

Bug: 328352850
Bug: 355684882
Test: see b/355684882
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0e55f685fedaf3c215b646c92d567d722d95c02e)
Merged-In: I02deca58bfd9a2cf169c2e58995cc42eeb854c8d
Change-Id: I02deca58bfd9a2cf169c2e58995cc42eeb854c8d

Change-Id: I27dd5cbaaa7a852226470475fa1db169593cce16

Y422_I's layout is: Y0 Cr0 Y1 Cb0 ...

...which means that successive luminance samples are separated by 2
bytes, not 1.

Bug: 351311764
Test: builds
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ff206d6d5d9150bbfeac0dfbe92825d97a7de5b2)
Merged-In: I4c24aae97ef052f6385281dd6e73f748d880decb
Change-Id: I4c24aae97ef052f6385281dd6e73f748d880decb

Change-Id: I930c21f6dee1f1e80a3d06b39970888f7dc7fee1

In order to fix a deadlock during display hotplug, the modesetting mutex
was changed from mStateLock to a granular DisplayModeController lock, in
the following CLs:

    I30ec756f134d2d67a70ac8797008dc792eac035e
    Iaae02d95e175e55f52f65da1481b64f1f533a04c (reverted)

This exposed a data race leading to a crash, which, unlike the deadlock,
affects all devices with refresh rate switching. The race will be fixed
by:

    If6141d2928643e82b3251b321e18c300cd8c201c (WIP)

As a stopgap until then, restore mStateLock (on top of the DMC lock) on
the main thread to fix the race, but reintroduce the deadlock. The lock
was already restored on the idle timer thread by the reverted CL above.

Fixes: 348827779
Flag: com.android.graphics.surfaceflinger.flags.connected_display
Test: Manual (foldable, connected display)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b2fc4235635f5160ed5ae35c1fbd1fcc3e45c59f)
Merged-In: Ie15de10d16eefeb65289574b120d2ef4cc09d6c0
Change-Id: Ie15de10d16eefeb65289574b120d2ef4cc09d6c0

Merge cherrypicks of ['googleplex-android-review.googlesource.com/28255837', 'googleplex-android-review.googlesource.com/28292328', 'googleplex-android-review.googlesource.com/28292329'] into 24Q3-release.

Change-Id: Iecd1587b163bf63ff24cbbae002d225016987a35

As a short-term measure to avoid a deadlock during display hotplug, skip
stopping and starting the pacesetter's idle timer on demotion/promotion.
This assumes that hotplug results in demoting/promoting the same display
as pacesetter, currently always the active internal display.

Fixes: 329450361
Flag: com.android.graphics.surfaceflinger.flags.connected_display
Test: Manual (foldable, connected display)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b972419619256ea07ebdb35b737946faf5c21bdc)
Merged-In: Ieeb026666c8abdd14e0d4690a624fb60306b1bc1
Change-Id: Ieeb026666c8abdd14e0d4690a624fb60306b1bc1

Since Id5cb29c3cbaa8ed455a15d8be3a32e79a470cce5, the pacesetter display
is always specified to Scheduler::promotePacesetterDisplayLocked, so the
fallback to pick the first display as the pacesetter (and std::optional
plumbing) is dead code.

Bug: 329450361
Flag: EXEMPT refactor
Test: presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:16d1b3ce1588cc2d12ff72957f5807ead487e8e2)
Merged-In: I831de5eef94eaefe0682f9c87ffe76acd50171b0
Change-Id: I831de5eef94eaefe0682f9c87ffe76acd50171b0

When idle timer times out on VRR, change the refresh rate
indicator to show "- -". The render rate doesn't cange as a result
of idleness.

Bug: 333443503
Test: manual
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:eba039c2d28646c5064a9a952faaba0cff6350cb)
Merged-In: Ie4f51a2a9da1a5e229b3504881117b12f1fd1b6a
Change-Id: Ie4f51a2a9da1a5e229b3504881117b12f1fd1b6a

Change-Id: I388c7f4ea6e4bf14c1fdd6202c7bc2703bd06fe2

Change a1742966 introduced a race condition where the notfiy_all is called before the mExtensionString is set.
Set mExtensionString before refCond.notify_all(); is called

Bug: 345419965
Bug: 346881664
Test: Ran EGL unit tests
(cherry picked from https://android-review.googlesource.com/q/commit:5e94634dc57024dcae2d1484758c2a9a7a55d55e)
Merged-In: Ifcb691f9b9769be494e204c97512c3f7fffec60a
Change-Id: Ifcb691f9b9769be494e204c97512c3f7fffec60a

Merge cherrypicks of ['android-review.googlesource.com/3152117', 'googleplex-android-review.googlesource.com/28106238'] into 24Q3-release.

Change-Id: If7d6a3aac0e552b8ce073a661d5bf4b2b0fd950d

Fixes a deadlock where screenshot requests are blocked
on the main thread which inturn is blocked by the
screenshot request finishing.

Flag: EXEMPT bug fix
Bug: 349776684
Test: presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5aadd249f326b21e5ef6cadfebc15b6a0a016816)
Merged-In: Ibf038ad6db3e87c84508d3e101ca1eb144836d7c
Change-Id: Ibf038ad6db3e87c84508d3e101ca1eb144836d7c

Instead of using PRODUCT_COPY_FILES to copy a source file to install,
define a prebuilt_etc module and add it to the PRODUCT_PACKAGES.
android.software.credentials.xml is to be installed in system for
GSI.

Bug: 345373198
Test: See if android.software.credentials.xml is installed in
      system/etc/permissions
(cherry picked from https://android-review.googlesource.com/q/commit:e1f9d9778f80c498b6c6747157006302224e652f)
Merged-In: Ib9f030e1e0ff6db55a6e07444943407f9ff1c1df
Change-Id: Ib9f030e1e0ff6db55a6e07444943407f9ff1c1df

Change-Id: Id35732bcee8281eeee000cfa1166d50636897d94

We were swapping a couple of boolean params when requesting
screenshots for region sampling, breaking region sampling for
secure layers in the process. Fix this by passing flags instead of
booleans in a long list of arguments and add a test to verify the
code path.

FLAG: EXEMPT bugfix
Fixes: 348944802
Test: presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:871886eebe469fc21568ff363993bde9a6593837)
Merged-In: I58f12e5cf81cb59115c1b9c500ac1e18a8ec72e5
Change-Id: I58f12e5cf81cb59115c1b9c500ac1e18a8ec72e5

Change-Id: I90ce026e60bf4a7542f4949514312de882a82f9b

Follow on to I7baa3e76af86329fb266395e63e92a0ba38967f4, which made a
lambda use a variable it did not capture correctly. Fix that capture.

Bug: 330806421
Bug: 347659752
Test: manual
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1972557dca9614dfd1c32fe34dd901d9edbf7fa9)
Merged-In: I3a8dd1670113111e01de3471b8061ff24dd0a115
Change-Id: I3a8dd1670113111e01de3471b8061ff24dd0a115

Change-Id: I1627826bdda8d1de4823d89ef39c5b95b90d04d0

The pacesetter display is demoted/promoted in response to a hotplug. On
foldables, the promoted display was hard-coded to the inner display, so
a hotplug while folded would incorrectly use that powered-off display as
the pacesetter, causing system-wide jank until the next fold/unfold.

Fixes: 347248313
Flag: EXEMPT bugfix
Test: Connect and disconnect external display while folded.
Test: Fold and unfold while external display is connected.
Test: Pacesetter is still correct on folded/unfolded boot.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3ff44c7e852f5614514a15dcec78ba7857e5d010)
Merged-In: Id5cb29c3cbaa8ed455a15d8be3a32e79a470cce5
Change-Id: Id5cb29c3cbaa8ed455a15d8be3a32e79a470cce5

Change-Id: I839140d230064e3a427032bf28ee2fe3feb4560a

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3128499



Change-Id: I8d0fc048bf128d6fa486498d9dde64275ef71bc8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3128499



Change-Id: I4afba61c7fea905b90087c9716d6a39879e536dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Change-Id: I1af433da09eba5ef89b222dae729dda71e1eda18

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2881062



Change-Id: Iff58010611b149bdd705fbcfd3b70af7aaa3d16c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2881062



Change-Id: I01353d70e4318e15928734b4eb2f6439dcf5a017
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Remove the fmtlib dependency which is not needed
anymore on Trusty. This should save us some space.

Bug: 302723053
Test: Build qemu-generic-arm64-test-debug
Change-Id: I925b7ade353e6a7975c41209bbe6a523380acb18

* changes:
  InputTracer: Add timestamp to perfetto trace packets
  InputDispatcher: Fix pointer count when canceling a subset of pointers

Use the event processing time as the packet timestamp for input events,
and use the delivery time as the packet timestamp for dispatch events.

Bug: 332714237
Bug: 210460522
Test: atest inputflinger_tests
Test: manual with perfetto
Change-Id: I30f4c21dfee68603d0dad01d205f8a5581e6db31

There was a bug in the logic for calculating the pointer coords and
properties for canceling a subset of pointers. It was introduced when we
refactored storing the coords in a vector rather than using a
fixed-length array with a pointerCount variable in the following change:
I91b4a88ec5df3f017ade8a6e55be3d3c1281de75

Bug: 346342507
Test: atest inputflinger_tests
Flag: NONE bug fix

Change-Id: Ie9a5fbd5ba1fd75c53b7289a93573ec2d0d1947b

Add a trace point for both SF and apps when the render rate
is overridden.

Bug: 347314033
Test: manual
Change-Id: I87dc9b17a4c1f97fa43b025cfa684f43c20c5a25