Commits · 5b4a48a90b2bbeb06778e130a29420e2cfa908e9 · halogenOS / android_frameworks_native

Sep 22, 2024

SurfaceFlinger: Allow forcing HWC brightness support · 5b4a48a9

Adithya R authored 2 years ago and

Simão Gomes Viana committed 5 months ago


Some vendors purposely disable brightness capability
even though the HWC completely supports it, in order
to leverage their custom brightness implementations.
One such example of this is in stock HWC of some
xiaomi devices.

Since light HAL offers lesser granual control than
HWC (since its in gamma space and not float), and
since it would be rather difficult to patch the blob
to return the right capabilities, allow forcing the
usage of HWC brightness functions via a prop:

ro.sf.force_hwc_brightness=1 (default 0).

Change-Id: I7d2fef03afbbb936572c717f769f30c9e49213e0
Signed-off-by: Adithya R <gh0strider.2k18.reborn@gmail.com>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

5b4a48a9

-O3 · 826a797d
Simão Gomes Viana authored 2 years ago and Simão Gomes Viana committed 5 months ago

826a797d

SF: Don't enable expensive rendering for unknown dataspace · 02671e04

Adithya R authored 2 years ago and

Simão Gomes Viana committed 5 months ago


Layer dataspace is initialized as unknown by default, unless
overriden by the buffer source. We don't require expensive
rendering for color conversion when the dataspace is unknown.

Change-Id: I079c520f63a65c77ba3162664656e607eafff991
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

02671e04

gui: Remove annoying logspam · 6617c9e1
Simão Gomes Viana authored 10 months ago
```
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>
```
6617c9e1

Sep 20, 2024

input: Bring back PointerProperties::copyFrom() · d88fe170

Edwin Moquete authored 11 months ago and

Simão Gomes Viana committed 5 months ago


libwfdnative compiled for 14 QPR1 depends on this symbol.

Change-Id: I7bc5ee3fb7760a9f470023cd0daa215b2e194dc1
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

d88fe170

Do not return glGetString error on desktop GL context · 49c6211b

Aaron Kling authored 6 years ago and

Simão Gomes Viana committed 5 months ago


Nvidia shield devices support using egl to switch to a full desktop
opengl context. In opengl 3.0+, GL_EXTENSIONS have to be retrieved
with glGetStringi and is invalid for glGetString. Thus,
eglMakecurrent will return a gl error if the case is not handled.
The logic here is building a wrapper for glGetStringi, thus the
error can be ignored. This patch allows GL_EXT_debug_marker to
still pushed into the tokenized extension string used by the
glGetStringi wrapper.

Change-Id: I9c599e10c62aabf684bde4e81719aa248327ac80
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

49c6211b

EGL: nvidia: For desktop gl contexts, use gles v2 hooks list · 043792b7
Aaron Kling authored 2 years ago and Simão Gomes Viana committed 5 months ago
```
Change-Id: Icd1e8e0c46c72bd87adb35faa2952d56b9ff2541
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>
```
043792b7

EGL: nvidia: Don't use extension map · 9a4fd485

Aaron Kling authored 2 years ago and

Simão Gomes Viana committed 5 months ago


The nvidia egl implementation exposes desktop opengl, which has
far too many extentions for the map to handle.

Change-Id: Id925c66fdf98108af126e9e02a38c696157576f2
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

9a4fd485

EGL: Loader: Enable desktop openGL on Nvidia platforms · 91eb4c8c

Billy Laws authored 4 years ago and

Simão Gomes Viana committed 5 months ago


There is some specific code I reversed from the EGL library that sets
the openGL bit in a data struct when getProcAddr is called with
eglSentinelNvFrameworks.

Change-Id: I9c1eaba65c65dfc9b3e500ad627a492ec6ce2f36
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

91eb4c8c

libgui: reset buffer count to max slots instead of returning BAD_VALUE. · 614c8fd6
Rajat Yadav authored 3 years ago and Simão Gomes Viana committed 5 months ago
```
CRs-Fixed: 3013293

Change-Id: Idfafcd6aa718054ff749bd5d1c7eb2630be0f109
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>
```
614c8fd6

Sep 19, 2024

Forward port 'Swap volume buttons' (2/3) · 3ac6c5dd

nadlabak authored 10 years ago and

Simão Gomes Viana committed 5 months ago


[mikeioannina]: Adjust for 5.0 changes
[LuK1337]: Adjust for 8.1 changes
[mikeioannina]: Adjust for 10.0 changes
[LuK1337]: Adjust for 11.0 changes
[LuK1337]: Adjust for 14.0 changes

Change-Id: I5ed4ae2b7e69e2ada067ed1d3524b3d3fad30e2e
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

3ac6c5dd

PowerManager.h: Define USER_ACTIVITY_FLAG values · 1a58a804

Corinna Vinschen authored 7 years ago and

Simão Gomes Viana committed 5 months ago


Change-Id: I90daada0d887008d56e84ce29b3f0b011a298698
Signed-off-by: Corinna Vinschen <xda@vinschen.de>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

1a58a804

EGL: Conditionally revert commit · 96dcf773

Danny Trunk authored 3 years ago and

Simão Gomes Viana committed 5 months ago

This conditionally reverts a commit [1]
which causes random camera crashes on tama devices

[1] https://github.com/LineageOS/android_frameworks_native/commit/a9550f3fe9097e0934e9b44c5aac6b914fb46aec



Change-Id: If3d9c722c63a9da2f9ca10e21de9d7bc6dba7c52
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

96dcf773

CompositionEngine: Request device composition for the Udfps touched layer · 3a671f12

daniml3 authored 3 years ago and

Simão Gomes Viana committed 5 months ago


The FOD layers should be always composed by the device to set the
custom zpos bits to the kernel. By default all layers are set to
device composition and the proprietary libsdmextension.so moves
some to client composition. Unfortunately that also affects the
Udfps touched layer. After this commit the layer below the Udfps
touched layer is forced to be client composition. For unknown
reasons libsdmextension will not change the Udfps touched layer
to client composition anymore.

tests:
- Run 'adb shell dumpsys SurfaceFlinger' and ensure that the Udfps
  touched layer is composed by the device
- Ensure that the Udfps touched layer correctly sets the zpos bits
  on the kernel while / after using WFD

Signed-off-by: daniml3 <danimoral1001@gmail.com>
Signed-off-by: Arian <arian.kulmer@web.de>
Change-Id: I8aeb98d18557ad4e971eaba74700ceb3058273ab
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

3a671f12

surfaceflinger: Add support for Udfps extension lib · f7cdb53a

Pierre-Hugues Husson authored 4 years ago and

Simão Gomes Viana committed 5 months ago


 * Supports changed z Udfps order
 * Supports changed Udfps usage bits

TheScarastic: Adapt to extension lib and support 12 BiometricPrompt
ArianK16a: Adapt layer name to UdfpsControllerOverlay for Android 13
    and only compare the prefix. Drop the BufferQueueLayer change
    because it seems unnecessary.

Co-authored-by: TheScarastic <warabhishek@gmail.com>
Change-Id: Id95aa73e06b4223a6b4f05c69fa2fc494f9a97b1
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

f7cdb53a

sf: Exclude VDS use of HWC on non-UM platforms · f7be8b32

dianlujitao authored 4 years ago and

Simão Gomes Viana committed 5 months ago


Author: Bruno Martins <bgcngm@gmail.com>
Date:   Wed Oct 14 23:45:14 2020 +0100
Edit:   Adapt to new lineage soong config

Change-Id: Ic0f314f4053628667a921951f610839f36a5079c
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

f7be8b32

sf: Allow WFD to use hwc in vendor frozen targets · 1dfe5f77
Rheygine Medel authored 2 years ago and Simão Gomes Viana committed 5 months ago
```
Change-Id: Iecd2be3eb8775855d82763f069a38bb70fe53d4e
CRs-Fixed: 3229968
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>
```
1dfe5f77

sf: Clean up properties for virtual display · c512caef

Rheygine Medel authored 2 years ago and

Simão Gomes Viana committed 5 months ago


Currently, the properties are used as follows:
1. debug.sf.enable_hwc_vds - allows IDs to be generated for VDs
2. vendor.display.vds_allow_hwc - allows WFD to use HWC path

With this change, HWC path is enabled for WFD with only the vendor
property set. All other virtual displays require both of the
properties enabled.

Change-Id: Iab2c8d15d2c1cf24be0d371af8892c346634507f
CRs-Fixed: 3204941
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

c512caef

sf: Align virtual display changes with CAF · 29882c1e

Michael Bestas authored 3 years ago and

Simão Gomes Viana committed 5 months ago


* These changes are part of CAF AOSP merge commits

Change-Id: I390f874347d259fca4429c19711be6c85b104090
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

29882c1e

SF: Fix HWC based virtual display creation · a07187fc

Rajat Yadav authored 3 years ago and

Simão Gomes Viana committed 5 months ago


Allow HWC based virtual display only for wifi display

CRs-Fixed: 2984439

Change-Id: Ifbb094a2a0101171b475bd5a60660a3599dce5ff
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

a07187fc

Remove use of VrFlinger from value-adds. · 5c2767fb
Chris Gross authored 4 years ago and Simão Gomes Viana committed 5 months ago
```
Bug: 169788930
Change-Id: Ic50f5675d0cd48f84fb9ff14221355741dc52129
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>
```
5c2767fb

sf: Fix virtual display related issues. · 16104ef9

Ramakant Singh authored 4 years ago and

Simão Gomes Viana committed 5 months ago


1. SurfaceFlinger: Fix virtual display related issues. 1) Validate
output
buffer usage bit appropriately Validate output buffer usage bit only
against GRALLOC_USAGE_HW_COMPOSER to differentiate GLES only
conposition
and HWC/MIXED composition. 2) Exclude video encoder usage for
scratch
buffer Sink and Scratch buffers in VDS are using same usage
flags. This
causes video encoder flag to be set for scratch buffers
Also. Exclude
video encoder flag from scratch buffer usage flags as
scratch buffers
are used only as write back input and not video
encoder input.

2. sf: Allow VDS to use HWC -- Preserve VDS layer
pixel format based on
GRALLOC flags. -- skip color layer for vds

3. sf: Add secure content support for VDS

4. sf: Enable GPU comp. for non-primary displays
Ensure that "Return
status" of dequeueBuffer() complies with API
	requirements. Client relies
on this status to call requestBuffer()
	upon reallocation.

5. sf: Enable UBWC on virtual display scratch buffer Set
	GRALLOC_USAGE_HW_FB usage flag on virtual display Scratch
	buffer to
	enable UBWC.

Change-Id: Ia49a175372ca187a295531e18f8e84dc22a19486
CRs-Fixed: 2656027
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

16104ef9

libui: Allow extension of valid gralloc 1.0 buffer usage bits · 07cda887

Kevin F. Haggerty authored 3 years ago and

Simão Gomes Viana committed 5 months ago


* Change I7f4174581e24e361577640b9263514a168ed482d implemented
  validation of the buffer description info prior to creating
  the descriptor. Some of our legacy devices need to whitelist
  additional usage bits to support various functionality.

libui: Extend adb95ae to Gralloc3
libui: Extend adb95ae to Gralloc4

This commit squashes:
  libui: Convert lineage product variables to soong config variables
  Change-Id: Ib687c966d4eafcc1128611b95ebed00fd0a8bfaf

Change-Id: Ie369e78f78e9ac0b18ab3dfea520d4f123005d92
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

07cda887

Add vendor version for libgui · ffa8fbe6

Vinay Verma authored 6 years ago and

Simão Gomes Viana committed 5 months ago


libstagefright_omx library need to be extended to vendor which
is depenednet on libgui which is a vndk_private lib.
Creating vendor version so that libstagefright_omx_ext can link
to libgui_vendor.

CRs-Fixed: 2258968
Change-Id: I777eebffc405c8bb74aab270e9f272c806501458
Signed-off-by: Volodymyr Zhdanov <wight554@gmail.com>
Signed-off-by: SamarV-121 <samarvispute121@pm.me>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

ffa8fbe6

Sep 18, 2024

Add dalvik-heap device configs for 8/12/16 GiB devices · 0db5ce15

Simao Gomes Viana authored 5 years ago and

Simão Gomes Viana committed 5 months ago


Change-Id: Icdfd3512a79d9935d3fdb611c96dc8fd91a5e1c5
Signed-off-by: DennySPB <dennyspb@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Simao Gomes Viana <simao@halogenos.org>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

0db5ce15

Jul 31, 2024

Merge cherrypicks of ['googleplex-android-review.googlesource.com/28535721'] into 24Q3-release. · f7274fca
Android Build Coastguard Worker authored 7 months ago
```
Change-Id: Iaacc63e7a24129abec9b177624c86cd722aba8c8
```
f7274fca

SF: VsyncTimeline::isVSyncInPhase should use display rate [unflagged] · 03ceb6d3

Ady Abraham authored 7 months ago

Remove the flag for the fix in commit 4a719e88 so it will be enabled on 24Q3 release.

Bug: 328352850
Bug: 355684882
Test: see b/355684882
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0e55f685fedaf3c215b646c92d567d722d95c02e)
Merged-In: I02deca58bfd9a2cf169c2e58995cc42eeb854c8d
Change-Id: I02deca58bfd9a2cf169c2e58995cc42eeb854c8d

03ceb6d3

Jul 24, 2024

Merge cherrypicks of ['googleplex-android-review.googlesource.com/28218707'] into 24Q3-release. · 228a3dd8
Android Build Coastguard Worker authored 7 months ago
```
Change-Id: I27dd5cbaaa7a852226470475fa1db169593cce16
```
228a3dd8

Use pixel stride of 2 for Y422_I's Y plane · bef25703

Alec Mouri authored 8 months ago

Y422_I's layout is: Y0 Cr0 Y1 Cb0 ...

...which means that successive luminance samples are separated by 2
bytes, not 1.

Bug: 351311764
Test: builds
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ff206d6d5d9150bbfeac0dfbe92825d97a7de5b2)
Merged-In: I4c24aae97ef052f6385281dd6e73f748d880decb
Change-Id: I4c24aae97ef052f6385281dd6e73f748d880decb

bef25703

Jul 23, 2024

Merge cherrypicks of ['googleplex-android-review.googlesource.com/28318758'] into 24Q3-release. · 4c39de57
Android Build Coastguard Worker authored 7 months ago
```
Change-Id: I930c21f6dee1f1e80a3d06b39970888f7dc7fee1
```
4c39de57

SF: Restore mStateLock mutex for modesetting · a515fd50

Dominik Laskowski authored 7 months ago

In order to fix a deadlock during display hotplug, the modesetting mutex
was changed from mStateLock to a granular DisplayModeController lock, in
the following CLs:

    I30ec756f134d2d67a70ac8797008dc792eac035e
    Iaae02d95e175e55f52f65da1481b64f1f533a04c (reverted)

This exposed a data race leading to a crash, which, unlike the deadlock,
affects all devices with refresh rate switching. The race will be fixed
by:

    If6141d2928643e82b3251b321e18c300cd8c201c (WIP)

As a stopgap until then, restore mStateLock (on top of the DMC lock) on
the main thread to fix the race, but reintroduce the deadlock. The lock
was already restored on the idle timer thread by the reverted CL above.

Fixes: 348827779
Flag: com.android.graphics.surfaceflinger.flags.connected_display
Test: Manual (foldable, connected display)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b2fc4235635f5160ed5ae35c1fbd1fcc3e45c59f)
Merged-In: Ie15de10d16eefeb65289574b120d2ef4cc09d6c0
Change-Id: Ie15de10d16eefeb65289574b120d2ef4cc09d6c0

a515fd50

Jul 20, 2024

Merge cherrypicks of ['googleplex-android-review.googlesource.com/28255837',... · f8483485

Android Build Coastguard Worker authored 7 months ago

Merge cherrypicks of ['googleplex-android-review.googlesource.com/28255837', 'googleplex-android-review.googlesource.com/28292328', 'googleplex-android-review.googlesource.com/28292329'] into 24Q3-release.

Change-Id: Iecd1587b163bf63ff24cbbae002d225016987a35

f8483485

SF: Do not toggle idle timer on display hotplug · 3a333064

Dominik Laskowski authored 8 months ago

As a short-term measure to avoid a deadlock during display hotplug, skip
stopping and starting the pacesetter's idle timer on demotion/promotion.
This assumes that hotplug results in demoting/promoting the same display
as pacesetter, currently always the active internal display.

Fixes: 329450361
Flag: com.android.graphics.surfaceflinger.flags.connected_display
Test: Manual (foldable, connected display)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b972419619256ea07ebdb35b737946faf5c21bdc)
Merged-In: Ieeb026666c8abdd14e0d4690a624fb60306b1bc1
Change-Id: Ieeb026666c8abdd14e0d4690a624fb60306b1bc1

3a333064

SF: Remove misleading pacesetter choice fallback · c2d89d65

Dominik Laskowski authored 8 months ago

Since Id5cb29c3cbaa8ed455a15d8be3a32e79a470cce5, the pacesetter display
is always specified to Scheduler::promotePacesetterDisplayLocked, so the
fallback to pick the first display as the pacesetter (and std::optional
plumbing) is dead code.

Bug: 329450361
Flag: EXEMPT refactor
Test: presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:16d1b3ce1588cc2d12ff72957f5807ead487e8e2)
Merged-In: I831de5eef94eaefe0682f9c87ffe76acd50171b0
Change-Id: I831de5eef94eaefe0682f9c87ffe76acd50171b0

c2d89d65

SF: add a new behaviour for idle timer on VRR · e2946321

Ady Abraham authored 8 months ago

When idle timer times out on VRR, change the refresh rate
indicator to show "- -". The render rate doesn't cange as a result
of idleness.

Bug: 333443503
Test: manual
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:eba039c2d28646c5064a9a952faaba0cff6350cb)
Merged-In: Ie4f51a2a9da1a5e229b3504881117b12f1fd1b6a
Change-Id: Ie4f51a2a9da1a5e229b3504881117b12f1fd1b6a

e2946321

Jul 15, 2024

Merge cherrypicks of ['android-review.googlesource.com/3147277'] into 24Q3-release. · f8cc08fa
Android Build Coastguard Worker authored 7 months ago
```
Change-Id: I388c7f4ea6e4bf14c1fdd6202c7bc2703bd06fe2
```
f8cc08fa

Fix race condition in extension string creation · f5df9718

Tom Murphy authored 8 months ago

Change a1742966 introduced a race condition where the notfiy_all is called before the mExtensionString is set.
Set mExtensionString before refCond.notify_all(); is called

Bug: 345419965
Bug: 346881664
Test: Ran EGL unit tests
(cherry picked from https://android-review.googlesource.com/q/commit:5e94634dc57024dcae2d1484758c2a9a7a55d55e)
Merged-In: Ifcb691f9b9769be494e204c97512c3f7fffec60a
Change-Id: Ifcb691f9b9769be494e204c97512c3f7fffec60a

f5df9718

Jul 10, 2024

Merge cherrypicks of ['android-review.googlesource.com/3152117',... · 29bd5a22

Android Build Coastguard Worker authored 8 months ago

Merge cherrypicks of ['android-review.googlesource.com/3152117', 'googleplex-android-review.googlesource.com/28106238'] into 24Q3-release.

Change-Id: If7d6a3aac0e552b8ce073a661d5bf4b2b0fd950d

29bd5a22

Enable single hop screenshots for only threaded re · 454f7f27

Vishnu Nair authored 8 months ago

Fixes a deadlock where screenshot requests are blocked
on the main thread which inturn is blocked by the
screenshot request finishing.

Flag: EXEMPT bug fix
Bug: 349776684
Test: presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5aadd249f326b21e5ef6cadfebc15b6a0a016816)
Merged-In: Ibf038ad6db3e87c84508d3e101ca1eb144836d7c
Change-Id: Ibf038ad6db3e87c84508d3e101ca1eb144836d7c

454f7f27

Define android.software.credentials.xml as prebuilt_etc · 4619b2a3

Justin Yun authored 8 months ago

Instead of using PRODUCT_COPY_FILES to copy a source file to install,
define a prebuilt_etc module and add it to the PRODUCT_PACKAGES.
android.software.credentials.xml is to be installed in system for
GSI.

Bug: 345373198
Test: See if android.software.credentials.xml is installed in
      system/etc/permissions
(cherry picked from https://android-review.googlesource.com/q/commit:e1f9d9778f80c498b6c6747157006302224e652f)
Merged-In: Ib9f030e1e0ff6db55a6e07444943407f9ff1c1df
Change-Id: Ib9f030e1e0ff6db55a6e07444943407f9ff1c1df

4619b2a3