Skip to content
Snippets Groups Projects
  1. Oct 27, 2023
  2. Oct 06, 2023
  3. Oct 05, 2023
  4. Sep 15, 2023
    • Keith Mok's avatar
      File size seal for memory mapped region · f2c1d9d2
      Keith Mok authored
      When using memfd for cross process communication, we always need to seal
      the file size, otherwise remote process and shrink the size we memory
      mapped and thus crash the originate process causing a DoS
      
      Bug: 294609150
      Test: Build
      Ignore-AOSP-First: security
      Change-Id: Ibc263c4f78df897e884378e3d984a188ca8772c7
      Merged-In: Ibc263c4f78df897e884378e3d984a188ca8772c7
      (cherry picked from commit 3d9f1e3b)
      f2c1d9d2
    • Keith Mok's avatar
      File size seal for memory mapped region · 77b758c5
      Keith Mok authored
      When using memfd for cross process communication, we always need to seal
      the file size, otherwise remote process and shrink the size we memory
      mapped and thus crash the originate process causing a DoS
      
      Bug: 294609150
      Test: Build
      Ignore-AOSP-First: security
      Change-Id: Ibc263c4f78df897e884378e3d984a188ca8772c7
      Merged-In: Ibc263c4f78df897e884378e3d984a188ca8772c7
      (cherry picked from commit 3d9f1e3b)
      77b758c5
  5. Sep 13, 2023
  6. Sep 05, 2023
    • Robert Phillips's avatar
      Don't look through the buffer cache in protected contexts · a0c7cca5
      Robert Phillips authored
      Test: manual - protected content in Netflix apk, even without blurring
      
      Without this change getOrCreateBackendTexture can return an
      un-Protected backend texture when a Protected one is required.
      This causes the Protected content draw to be dropped.
      
      Note: This CL originally landed in main as part of a broader fix for
      blurring protected content, but it has been discovered to fix other
      issues with protected content that were otherwise still visible in
      this branch.
      
      Bug: 242266174
      Bug: 294357792
      Change-Id: I9d7bab890ae8d88656e77dede962b40e926580c8
      (cherry picked from commit 59f71734)
      Merged-In: I9d7bab890ae8d88656e77dede962b40e926580c8
      a0c7cca5
  7. Aug 31, 2023
    • Patrick Williams's avatar
      Improve updateInputFlinger performance · d80fdc48
      Patrick Williams authored
      This change improves the performance of the WindowInfosListenerInvoker work done on SurfaceFlinger's background executor thread. The primary optimization made is not sending a WindowInfosReportedListener with every call to WindowInfosListener.onWindowInfosChanged. Instead, we send a new interface, WindowInfosPublisher, and a unique listener id to listeners when they're added.  Listeners call WindowInfosPublisher.ackWindowInfosReceived with their id after processing each update.
      
      From traces taken during development, the new code is a major improvement, taking about 15% of the time spent previously on SurfaceFlinger's background thread for sending window infos. Performance with this change seems roughly in line with the performance in T.
      
      Bug: 290377931
      Test: atest WindowInfosListenerTest
      Test: atest WindowInfosListenerInvokerTest
      Test: manually killing system server and checking valid state on restart
      Change-Id: Ib39ba935727df0bc1ab4030bcfe8301de7e64805
      (cherry picked from commit acd2258a)
      (cherry picked from commit e8a7ab25)
      Merged-In: Ib39ba935727df0bc1ab4030bcfe8301de7e64805
      
      This reverts commit a8ce8fc1.
      
      Change-Id: I3a9a5b5d397d6d37e9b81070a344a0202ce0f927
      d80fdc48
    • Ken Chen's avatar
      Revert "Improve updateInputFlinger performance" · a8ce8fc1
      Ken Chen authored
      This reverts commit 82f3463d.
      
      Reason for revert: Broken Build 10741338 on git_udc-mainline-prod on mainline_modules_arm-userdebug 
      Bug: 298282482
      
      Change-Id: I9a8eaaff637017cd84caaa5c0d570e24f257ed81
      a8ce8fc1
  8. Aug 30, 2023
    • Patrick Williams's avatar
      Improve updateInputFlinger performance · 82f3463d
      Patrick Williams authored
      This change improves the performance of the WindowInfosListenerInvoker work done on SurfaceFlinger's background executor thread. The primary optimization made is not sending a WindowInfosReportedListener with every call to WindowInfosListener.onWindowInfosChanged. Instead, we send a new interface, WindowInfosPublisher, and a unique listener id to listeners when they're added.  Listeners call WindowInfosPublisher.ackWindowInfosReceived with their id after processing each update.
      
      From traces taken during development, the new code is a major improvement, taking about 15% of the time spent previously on SurfaceFlinger's background thread for sending window infos. Performance with this change seems roughly in line with the performance in T.
      
      Bug: 290377931
      Test: atest WindowInfosListenerTest
      Test: atest WindowInfosListenerInvokerTest
      Test: manually killing system server and checking valid state on restart
      Change-Id: Ib39ba935727df0bc1ab4030bcfe8301de7e64805
      (cherry picked from commit acd2258a)
      (cherry picked from commit e8a7ab25)
      Merged-In: Ib39ba935727df0bc1ab4030bcfe8301de7e64805
      82f3463d
  9. Aug 04, 2023
    • Daniel Norman's avatar
      Lower severity for invalid accessibility hover event stream to ERROR. · 2f99cdb9
      Daniel Norman authored
      LOG(FATAL) crashes the device, which is very severe for the user.
      
      The accessibility hover event stream has consistency issues that we
      are actively fixing, but these fixes have not yet had time to soak.
      Instead of cherrypicking the fix, instead we can demote the severity
      of the log so that errors do not crash the device.
      
      Bug: 286037469
      Test: atest InputDispatcherTest#InvalidA11yHoverStreamDoesNotCrash
      Test: Use talkback, repeatedly enter touch exploration while also
            tapping with another finger. Eventually observe the failure
            message which is now an ERROR instead of crashing the device
            with a FATAL.
      Change-Id: Iceea086345691cdad8ca5e092629de094d666de1
      Merged-In: I1d6f091376b59279f11a04d02a875991a6384e31
      2f99cdb9
  10. Aug 03, 2023
  11. Jul 28, 2023
  12. Jul 27, 2023
  13. Jul 26, 2023
    • Eino-Ville Talvala's avatar
      UltraHDR: Add Adobe HDR gain map notice · 9438cea8
      Eino-Ville Talvala authored
      Bug: 292284515
      Test: Builds
      Change-Id: Ifd263d93e1c1b8bb8043712283e38e4434079f85
      9438cea8
    • Leon Scroggins III's avatar
      RenderEngine: don't blur when using protected content · 247b2418
      Leon Scroggins III authored
      Work around a bug by skipping blur when using protected content.
      
      Bug: 244398863
      Bug: 270314344
      Bug: 205516620
      Bug: 242266174
      Bug: 213116783
      Test: manual (ExoPlayer)
      Change-Id: Ifcacbd4c44aee1a504a7c46f3fece51004ed7f37
      (cherry picked from commit 4623eeb2)
      Merged-In: Ifcacbd4c44aee1a504a7c46f3fece51004ed7f37
      247b2418
    • Leon Scroggins III's avatar
      RenderEngine: Limit the size of blur input to the display size · 763e450b
      Leon Scroggins III authored
      Some layers are extraordinarily large. In the particular case we've
      found, the layer does not have any content, but even if it did, content
      outside the display would not impact the blur. So limit the size of the
      rectangle we use for blurring, which in turn limits the size of the
      buffers we allocate to compute the blur.
      
      Use the canvas' existing clip, which has already been adjusted to the
      size of the display.
      
      Bug: 283427479
      Bug: 292539958
      Test: manual (logcat)
      Change-Id: I17e646cce0dca02f4e6a18032ecd1e9120fcf880
      Merged-In: I17e646cce0dca02f4e6a18032ecd1e9120fcf880
      763e450b
  14. Jul 11, 2023
Loading