This reverts commit a4dfaaa4.

dianlujitao authored 4 years ago and Noah Anleitner committed 2 months ago

Author: Bruno Martins <bgcngm@gmail.com>
Date:   Wed Oct 14 23:45:14 2020 +0100
Edit:   Adapt to new lineage soong config

Change-Id: Ic0f314f4053628667a921951f610839f36a5079c
Signed-off-by: N0m4n904 <noah.anleitner@halogenos.org>

Rheygine Medel authored 2 years ago and Noah Anleitner committed 2 months ago

Change-Id: Iecd2be3eb8775855d82763f069a38bb70fe53d4e
CRs-Fixed: 3229968
Signed-off-by: N0m4n904 <noah.anleitner@halogenos.org>

Rheygine Medel authored 2 years ago and Noah Anleitner committed 2 months ago

Currently, the properties are used as follows:
1. debug.sf.enable_hwc_vds - allows IDs to be generated for VDs
2. vendor.display.vds_allow_hwc - allows WFD to use HWC path

With this change, HWC path is enabled for WFD with only the vendor
property set. All other virtual displays require both of the
properties enabled.

Change-Id: Iab2c8d15d2c1cf24be0d371af8892c346634507f
CRs-Fixed: 3204941
Signed-off-by: N0m4n904 <noah.anleitner@halogenos.org>

Michael Bestas authored 3 years ago and Noah Anleitner committed 2 months ago

* These changes are part of CAF AOSP merge commits

Change-Id: I390f874347d259fca4429c19711be6c85b104090
Signed-off-by: N0m4n904 <noah.anleitner@halogenos.org>

Chris Gross authored 4 years ago and Noah Anleitner committed 2 months ago

Bug: 169788930
Change-Id: Ic50f5675d0cd48f84fb9ff14221355741dc52129
Signed-off-by: N0m4n904 <noah.anleitner@halogenos.org>

Ramakant Singh authored 4 years ago and Noah Anleitner committed 2 months ago

1. SurfaceFlinger: Fix virtual display related issues. 1) Validate
output
buffer usage bit appropriately Validate output buffer usage bit only
against GRALLOC_USAGE_HW_COMPOSER to differentiate GLES only
conposition
and HWC/MIXED composition. 2) Exclude video encoder usage for
scratch
buffer Sink and Scratch buffers in VDS are using same usage
flags. This
causes video encoder flag to be set for scratch buffers
Also. Exclude
video encoder flag from scratch buffer usage flags as
scratch buffers
are used only as write back input and not video
encoder input.

2. sf: Allow VDS to use HWC -- Preserve VDS layer
pixel format based on
GRALLOC flags. -- skip color layer for vds

3. sf: Add secure content support for VDS

4. sf: Enable GPU comp. for non-primary displays
Ensure that "Return
status" of dequeueBuffer() complies with API
	requirements. Client relies
on this status to call requestBuffer()
	upon reallocation.

5. sf: Enable UBWC on virtual display scratch buffer Set
	GRALLOC_USAGE_HW_FB usage flag on virtual display Scratch
	buffer to
	enable UBWC.

Change-Id: Ia49a175372ca187a295531e18f8e84dc22a19486
CRs-Fixed: 2656027
Signed-off-by: N0m4n904 <noah.anleitner@halogenos.org>

jiayongqiang authored 3 months ago and Simão Gomes Viana committed 2 months ago

If a invisible parent layer set a fixedTransformHint, the sub layers
of this parent layer should be updated in time, especially in the
occation that when a landscape Activity exit and return to vertical
Activity.

It can optimize performance by avoiding unnecessary buffer
reallocation while dequeuBuffer for sub layers.

Change-Id: I5327591af6c2a4ba290d2ea2059a407171e47ecf
Signed-off-by: jiayongqiang <jiayongqiang@xiaomi.com>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

pjgowtham authored 5 months ago and Simão Gomes Viana committed 2 months ago

Change-Id: I367b2c395aeb8cb7cb9e3cc38eca98477befe007
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Adithya R authored 2 years ago and Simão Gomes Viana committed 2 months ago

Some vendors purposely disable brightness capability
even though the HWC completely supports it, in order
to leverage their custom brightness implementations.
One such example of this is in stock HWC of some
xiaomi devices.

Since light HAL offers lesser granual control than
HWC (since its in gamma space and not float), and
since it would be rather difficult to patch the blob
to return the right capabilities, allow forcing the
usage of HWC brightness functions via a prop:

ro.sf.force_hwc_brightness=1 (default 0).

Change-Id: I7d2fef03afbbb936572c717f769f30c9e49213e0
Signed-off-by: Adithya R <gh0strider.2k18.reborn@gmail.com>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Simão Gomes Viana authored 2 years ago and Simão Gomes Viana committed 2 months ago

Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Adithya R authored 2 years ago and Simão Gomes Viana committed 2 months ago

Layer dataspace is initialized as unknown by default, unless
overriden by the buffer source. We don't require expensive
rendering for color conversion when the dataspace is unknown.

Change-Id: I079c520f63a65c77ba3162664656e607eafff991
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

nadlabak authored 10 years ago and Simão Gomes Viana committed 2 months ago

[mikeioannina]: Adjust for 5.0 changes
[LuK1337]: Adjust for 8.1 changes
[mikeioannina]: Adjust for 10.0 changes
[LuK1337]: Adjust for 11.0 changes
[LuK1337]: Adjust for 14.0 changes
[xdevs23]: Adjust for 15.1 changes

Change-Id: I5ed4ae2b7e69e2ada067ed1d3524b3d3fad30e2e
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

daniml3 authored 3 years ago and Simão Gomes Viana committed 2 months ago

The FOD layers should be always composed by the device to set the
custom zpos bits to the kernel. By default all layers are set to
device composition and the proprietary libsdmextension.so moves
some to client composition. Unfortunately that also affects the
Udfps touched layer. After this commit the layer below the Udfps
touched layer is forced to be client composition. For unknown
reasons libsdmextension will not change the Udfps touched layer
to client composition anymore.

tests:
- Run 'adb shell dumpsys SurfaceFlinger' and ensure that the Udfps
  touched layer is composed by the device
- Ensure that the Udfps touched layer correctly sets the zpos bits
  on the kernel while / after using WFD

Signed-off-by: daniml3 <danimoral1001@gmail.com>
Signed-off-by: Arian <arian.kulmer@web.de>
Change-Id: I8aeb98d18557ad4e971eaba74700ceb3058273ab
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Pierre-Hugues Husson authored 4 years ago and Simão Gomes Viana committed 2 months ago

 * Supports changed z Udfps order
 * Supports changed Udfps usage bits

TheScarastic: Adapt to extension lib and support 12 BiometricPrompt
ArianK16a: Adapt layer name to UdfpsControllerOverlay for Android 13
    and only compare the prefix. Drop the BufferQueueLayer change
    because it seems unnecessary.

Co-authored-by: TheScarastic <warabhishek@gmail.com>
Change-Id: Id95aa73e06b4223a6b4f05c69fa2fc494f9a97b1
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Rajat Yadav authored 3 years ago and Simão Gomes Viana committed 2 months ago

Allow HWC based virtual display only for wifi display

CRs-Fixed: 2984439

Change-Id: Ifbb094a2a0101171b475bd5a60660a3599dce5ff
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Parent bug: b/353324127. Enabling `thread-safety-reference-return`
to allow developers to utilize Clang thread safety guardrails
(GUARDED_BY, REQUIRES, EXCLUDES).

Added NO_THREAD_SAFETY_ANALYSIS annotations to violating functions.
If this is not desired, please respond with concerns
or preferred fix.

Bug: 354740314
Flag: TEST_ONLY
Test: m out/soong/.intermediates/frameworks/native/services/surfaceflinger/tests/unittests/libsurfaceflinger_unittest/android_x86_silvermont/obj/frameworks/native/services/surfaceflinger/tests/unittests/CommitTest.o
Change-Id: I9be1254c3e2685b0aa950b314c581824f40ce26c

This reverts commit 3118f969.

Reason for revert: b/368514217

Change-Id: Id69a0bd8850d2b6c093f7ce78817cdf5705215b1

Remove unused methods in legacy layer code.

Flag: EXEMPT flag removal
Bug: 330785038
Test: presubmit
Change-Id: I463f4a0c0a64a059babd5608ba4a4311ff6e2354

Remove unused methods in legacy layer code.

Flag: EXEMPT flag removal
Bug: 330785038
Test: presubmit
Change-Id: I097480082e95bb38d716336fa1909103c3593494

Remove unused methods in legacy layer code.

Flag: EXEMPT flag removal
Bug: 330785038
Test: presubmit
Change-Id: I0c008ea8548ef18c86bd99280f9c1f202f656cc9

Currently, the key remapping operation occurs on a non-Reader thread,
which leads to concurrent operations on the KCM object by this thread
and the Reader, causing unpredictable concurrency issues.

Here, we move this operation to the Reader thread, aligning it with
most configuration refresh methods, which can resolve the
aforementioned issues.

Additionally, we are removing the device traversal method on the Java
side because we actually intend for the key remapping operation to
apply to all full-keyboard devices. This can be fully achieved during
the InputReader refresh, so we are also removing the deviceId parameter
from the remapping interface.

There should be no behavioral changes.

Bug: 358042225
Test: atest CtsInputTestCases
Test: atest InputTests
Test: atest inputflinger_tests
Flag: EXEMPT refactor

Change-Id: I6ab802b70dc1242c796f672ac30672d10e34857f
Signed-off-by: Linnan Li <lilinnan@xiaomi.corp-partner.google.com>

Parent bug: b/353324127. Enabling `thread-safety-reference-return`
to allow developers to utilize Clang thread safety guardrails.

The surfaceflinger unittest suite currently does not untilize mutex
locks when calling required thread-safe variables.

Example error:
frameworks/native/services/surfaceflinger/tests/unittests/TestableScheduler.h:133:52
error: returning variable 'mAttachedChoreographers' by reference
requires holding mutex 'mChoreographerLock' exclusively
[-Wthread-safety-reference-return]

Added NO_THREAD_SAFETY_ANALYSIS annotations to violating functions.

Bug: 354740314
Test: make

Change-Id: I95793ab942207660ea8e49cfd50d089e956a7ada

Disable a primaryRangeIsSingleRate section on dVRR and allow late touch
boost to trigger when no layer score. On dVRR display, the primary
physical range may be a single rate,
but late touch boost should still be able to trigger.

Bug: 353142444
Bug: 362379874
Flag: EXEMPT_bugfix
Test: atest libsurfaceflinger_unittest
Test: Twitter scrolling with and without video, with policy backdoor
Test: notification shade scrolling with policy backdoor
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7bedfbf0d7b106702a241a64a79c36205606496c)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:14e725f4ba7d1f71af2067945498a676372e0499)
Merged-In: Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498
Change-Id: Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498

Layer snapshots with buffers but without inputinfo were not sent to input or other window info listeners. This was due to a bug in how we checked to see if the layer needed an input info. FIx this to send SurfaceView layers to window info listeners.

Fixes: 365167765
Test: LayerSnapshotTest
Test: LayerLifecycleManagerTest
Flag: EXEMPT bugfix
Change-Id: I49e5d1e503af860a8324cc8b36589748ca2b7a25

Disable a primaryRangeIsSingleRate section on dVRR and allow late touch
boost to trigger when no layer score. On dVRR display, the primary
physical range may be a single rate,
but late touch boost should still be able to trigger.

Bug: 353142444
Bug: 362379874
Flag: EXEMPT_bugfix
Test: atest libsurfaceflinger_unittest
Test: Twitter scrolling with and without video, with policy backdoor
Test: notification shade scrolling with policy backdoor
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7bedfbf0d7b106702a241a64a79c36205606496c)
Merged-In: Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498
Change-Id: Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498

Read whether key repeats are disabled via settings and disable
generation of key repeats if so.

Bug: 336585002
Test: atest InputDispatcherKeyRepeatTest
Test: atest InputManagerServiceTests
Flag: com.android.input.flags.keyboard_repeat_keys
Change-Id: I871bbfc0808bde4a6f85b7ea47ea92d4e80156c7

The dispatcher crashes whenever we try adding pointers to a target,
but the target already had those pointers under a different mode.
Only one dispatch mode is allowed for each event, per target.

That's generally true, but there were instances where we ended up
with multiple dispatch modes for the same event.

For example, if a window changes bounds (for example, becomes hidden, or
the touchable region shrinks), the pointer would no longer be inside
that window. And if this window is also watching for outside touch,
then an ACTION_DOWN event of the mouse would cause 2 things to happen:
1) This would cause HOVER_EXIT, since the pointer is no longer in that
   window
2) This would case ACTION_OUTSIDE, since the pointer is tapped outside
   of the window's bounds.

This previously led to a crash in dispatcher because there would be two
different dispatch modes for the same window for the same ACTION_DOWN
event.

Update being done here:
When a window resizes, it's possible that the hovering pointer is no
longer inside that window's bounds. We should generate a HOVER_EXIT
event at that point; this will ensure that the next mouse event is still
maintaining the contract that it's only dispatched with a single mode.

Bug: 346121425
Test: TEST=inputflinger_tests; m $TEST && $ANDROID_HOST_OUT/nativetest64/$TEST/$TEST --gtest_filter="*MouseClickUnderShrinkingTrustedOverlay"
Flag: EXEMPT bugfix
Change-Id: Ia5e5ac0421b127231d36ed375538eaebfb8994ac

Bug: 322036393
Test: N/A
Flag: com.android.graphics.libgui.flags.edge_extension_shader
Change-Id: Idd44d0970e6a4e65888ba7122db97611e1bf22ac

Bug: 347122505
Flag: com.android.input.flags.enable_input_policy_profile
Test: check the priority and latency of input thread in Perffeto
Change-Id: I428b9e718eace0bc39f1965d98475eebe9d3aaa5

b/365166534 was caused by a WithPointer… matcher not checking that its
pointer index was in bounds, and this check is missing from a couple of
other WithPointer… matchers. Add it, so that more bugs like this can be
found instantly in future rather than causing flaky assertions against
uninitialized memory.

Test: atest inputflinger_tests
Bug: 365166534
Flag: TEST_ONLY
Change-Id: I57d23909888749e15d4d034ddb0c091336b016d1

Test: Presubmit
Fixes: 357599979
Flag: EXEMPT bug fix
Change-Id: I705579eef8cc5fe371f3e57d0e16e8df1acfc3c5

When "show touches" is enabled, we show the spot hover icon when the
stylus is hovering. However, when an app is allowed to override the icon
for a hovering stylus, we were never showing the spot hover icon.

In this CL, we ensure that the spot hover icon is visible for a hovering
stylus when "show touches" is enabled and the app has not specified an
icon to use.

Bug: 342067371
Test: atest inputflinger_tests
Flag: EXEMPT bug fix
Change-Id: Iddf637c87ecba928a5a227a8efc0dd436b9528c7

While looking into some other Scheduler changes, I noticed that both
Scheduler::mRenderEventConnection and
Scheduler::mLastCompositeEventConnection are initialized but otherwise
unused. Scheduler::getEventConnection() is never called to retrieve
either value.

As there doesn't seem to be any use for them, let's remove them.

This change also required removing test fixture setup from the unit
tests, as the tests worked to install test double implementations.

Test: atest libsurfaceflinger_unittest
Bug: None
Flag: EXEMPT dead code

Change-Id: Ic004df96dd5fe3dadd0cd1455cd85506736a1875

In the old touchpad stack, when a touchpad was captured we'd report
AXIS_RELATIVE_(X|Y) values for each finger, as offsets from the location
it had in the previous frame. When I implemented captured mode in the
new stack I didn't realize this, so the new stack introduced in Android
U doesn't report them. This causes problems for games that capture the
mouse pointer and use the relative axes for camera movement.

This is attempt 2; the original CL [0] had a unit test that was flaky
due to it accidentally making assertions about uninitialized memory. The
changes since that CL are to TwoFingers_motionReportedCorrectly in
CapturedTouchpadEventConverter_test.cpp (to change the last
WithPointerRelativeMotion call to WithRelativeMotion) and
TestEventMatchers.h (to use a class for WithPointerRelativeMotion and to
check for out-of-range pointer indexes).

[0]: Change ID I8a1caa4c9315dd41bc712fd9467146bb608cf6f3

Bug: 330522990
Bug: 365166534
Test: check the axis values using a test app
Test: $ atest inputflinger_tests:CapturedTouchpadEventConverterTest
Flag: com.android.input.flags.include_relative_axis_values_for_captured_touchpads
Change-Id: If6828f95e3aa359af479a708f95fbb5e31e5bc9a

When minFrameInterval is 0 then return the shift was 0.

Bug: 365442861
Merged-In: I00c1795c11f1dc38e6b4ce3ff49fae79e265f25c
Change-Id: I00c1795c11f1dc38e6b4ce3ff49fae79e265f25c

In the major Android version upgrade from 13 to 14, the addCommittedTransactions function in the applyTransactionsLocked function that requires the vsyncId parameter has been moved to the updateLayerSnapshots and updateLayerSnapshotsLegacy functions. The rest of the operations in the applyTransactionsLocked function no longer require the vsyncId parameter, so the declaration and definition information about vsyncId in the applyTransactionsLocked function can be removed here.

Bug: 362415544

Change-Id: Ic4ded171e90bcfb7a0d58df2c272f4c219be3a04
Merged-In: Ic4ded171e90bcfb7a0d58df2c272f4c219be3a04
Signed-off-by:  <xiangshuangxi@xiaomi.corp-partner.google.com>

GpuWorkTracepointTest test requires GPU driver to generate kernel
tracepoint events which should only be tested with real devices,
but not with emulators. Replacing RestrictedBuildTest annotation
with RequiresDevice to correctly indicate this.

Bug: b/352538275
Test: atest GpuWorkTracepointTest
Flag: EXEMPT test fix
Change-Id: I57f5f035a6ea7ac12e6fb6c619385af75defda2a

These tests fail to build for coverage when Rust host coverage is
enabled. This is a temporary workaround until the underlying issue is
resolved.

Bug: 338242594
Bug: 330591720
Test: m libinput_tests CLANG_COVERAGE=true NATIVE_COVERAGE_PATHS='*'
Test: m inputflinger_tests CLANG_COVERAGE=true NATIVE_COVERAGE_PATHS='*'
Merged-In: Idf82d31ce8a7078c3502b7bcb7c959177a1bbe4e
Change-Id: Ibe21b560228f6ca3f8acd61bff1763492428fe29