- Jun 22, 2023
-
-
Siarhei Vishniakou authored
This is needed to further understand the dispatching decisions. In one of the bugs, the dispatcher sent an event to two windows and ended up with two foreground windows at the same time. That shouldn't occur. This logging in needed to figure out how the dispatcher got there. Bug: 287860440 Test: none Change-Id: I1021ab19ee450361974a61d39c45fd5f134b100b
-
Siarhei Vishniakou authored
-
Siarhei Vishniakou authored
Before this CL, NotifyMotionArgs stored PointerCoords and PointerProperties in a fixed-size array. Upon creation of a new object, some of that data typically remained uninitialized. At the same time, the copy assignment operator was defaulted, which meant that the uninitialized data was getting accessed in order to copy the object. The sanitizers identify this as a problem and crash. To fix this, store these objects inside vectors. Bug: 271455682 Test: atest inputflinger_tests Change-Id: I9dba29f75df59a21f8ed7fd0f46fd1f6d45f2eef
-
Chris Glover authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23516798 Change-Id: I3edb6e4e8b6c9876a49c6058c6e45971a3f8119e Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Chris Glover authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23516798 Change-Id: Ia52440563f8e4778a1c0d28f76824f2c5444e05c Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Cody Heiner authored
-
- Jun 21, 2023
-
-
Treehugger Robot authored
-
Cody Heiner authored
This allows these builders to be accessed by code in other locations, which is useful for writing other tests. Test: `atest frameworks/native/services/inputflinger/tests/InputDispatcher_test.cpp` Test: `atest frameworks/native/services/inputflinger/tests/InputDeviceMetricsCollector_test.cpp` Bug: 268245099 Change-Id: I7bca675e0b83673a30db2f1c06abda4369b69c42
-
TreeHugger Robot authored
-
Harry Cutts authored
-
Chris Glover authored
ag/22764137 added support for HLG formats, but the spec change in the Khronos gitlab hadn't landed yet. The enum I used had already been used by an unpublished NVIDIA EXT, so I needed to choose a different one. This change uses the new one which is the final correct enum found here: https://github.com/KhronosGroup/EGL-Registry/commit/526f9a6471106090e44b8d6a123f78886d5d88fa Bug: 277210442 Test: Manually ran new test in CL https://gerrit.khronos.org/c/vk-gl-cts/+/11608 Change-Id: I5c163b7ef2c3e6fa6f90ac8de6f75a7b7e67cf8c
-
- Jun 20, 2023
-
-
Siarhei Vishniakou authored
Currently, our fuzzers are only built for device. In this CL, we unify some of the Android.bp definitions and allow building these for host. Bug: 271455682 Test: m checkinput Change-Id: I2140c6ceb34aefb997d94ce36a4acdf9073594cc
-
Prabir Pradhan authored
Bug: 286428012 Test: presubmit Change-Id: I039e2892274b293eeea4a167d748234a4170541e
-
Vishnu Nair authored
-
Dominik Laskowski authored
Introduce FrameTargeter to isolate a display's per-frame metrics around past/upcoming deadline targets. The Scheduler updates the FrameTargeter on frame begin/end, whereas ICompositor (concretely SurfaceFlinger) has read-only access via the FrameTarget interface. For now, only instantiate the pacesetter's FrameTargeter. The reverted Idf9f43b37f3479c94a478d154eaa46f43e0c6c9d had an incorrect functional change that adjusted `earliestPresentTime` based on the past VSYNC, which differs from the previous frame's VSYNC when targeting two VSYNCs ahead. This CL restores the `earliestPresentTime` to be relative to the previous frame. Bug: 262269033 Bug: 241285475 Bug: 241285191 Test: Perfetto Test: dumpsys SurfaceFlinger --scheduler Test: atest libscheduler_test:FrameTargeterTest Test: systemui-bubble-1-jank-suite on raven-userdebug Change-Id: I584e299e8af55baae1125f45fd47b13f705a268c
-
Treehugger Robot authored
-
Harry Cutts authored
Bug: 280604085 Test: touch touchpad with fingers and palm, make some gestures, then check metrics reported through statsd_testdrive for atom 10191 Change-Id: Ie7985cdfa628c63514aa1264287eb83dbfbd7625
-
- Jun 19, 2023
-
-
Harry Cutts authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23745905 Change-Id: Iec9b46ce34d93ad411f14969207a4f76b8487d62 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Harry Cutts authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23745905 Change-Id: I9dd4d46650a86b6b9d96ea49da86fbf235446d42 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Harry Cutts authored
Uncaptured touchpads (with DeviceMode::POINTER) still on the old stack (i.e. the Sony DualShock 4 touchpad) were having touches ignored if they started at coordinates that would be outside of the bounds of the touchscreen. Since touchpads use relative motions and don't directly relate raw touch locations to screen locations, this was incorrect, and caused touches to be ignored with certain screen/touchpad dimension and orientation combinations. Bug: 280396539 Test: connect Sony DualShock 4 by USB, rotate screen to portrait, check touches starting in all areas of the pad are turned into pointer movements Test: atest inputflinger_tests Change-Id: I9a92ba79246ee8fc25418c2e248ae2c3839a0d58
-
Arpit Singh authored
-
- Jun 17, 2023
-
-
Peiyong Lin authored
-
- Jun 16, 2023
-
-
Peiyong Lin authored
Rename variables to clarify the meanings, remove unused methods. Bug: b/283858001 Test: test with camera with dialog on Test: atest CtsAngleIntegrationHostTestCases Change-Id: I1db89b79879dec663f198fd3faad7501a3511698
-
Nikhil Kumar authored
Merge "Use unsigned calling_uid in case of bug report triggered from adb" into udc-dev am: 90721097 am: 723c2365 Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23710687 Change-Id: I50bc2e4ba55eaa94dd0ddc509b038ac7130c8af8 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Nikhil Kumar authored
Merge "Use unsigned calling_uid in case of bug report triggered from adb" into udc-dev am: 90721097 Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23710687 Change-Id: I6e9fb4a6c9b7b7427e6d9d9fe55664f5fc114b96 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Nikhil Kumar authored
-
Nikhil Kumar authored
-
Nolan Scobie authored
* changes: Move libgui_test to presubmit, modulo some exclusions Ensure usage flags are always passed to dequeueBuffer in libgui_tests Make all libgui tests print their name to logcat on begin/end
-
Siarhei Vishniakou authored
Currently, the InputEventLookup class uses static fields, which means that they are getting initialized early. This causes issues with address sanitizers. The sanitizers report a memory leak with the purely static approach. It's not clear whether this is an actual issue, or just a bug elsewhere in the system. To get around these problems, create a singleton instance of InputEventLookup. This singleton will be created upon the first access to any of its static functions. This helps resolves the sanitizer issues. Bug: 271455682 Test: FUZZER=inputflinger_input_dispatcher_fuzzer; m $FUZZER && out/host/linux-x86/fuzz/x86_64/$FUZZER/$FUZZER Note: test requires more CLs that are upcoming Change-Id: Id655554db9c706f5d45eaebbee55e12519dcfdc8
-
Nikita Ioffe authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23710044 Change-Id: I77de731bad527332cd7d2c8fe65601dbd3a43339 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Nikita Ioffe authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23710044 Change-Id: I013021ffb7e906d3e63181280614366da9db880c Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Vishnu Nair authored
Flush always on transaction traces to disk when we detect errors like: - out of order buffer updates or cycles in the layer hierarchy so it easier to investigate issues from dogfood (ref bug b/272189296) Bug: 282110579, 238781169 Fixes: 277265947 Test: presubmit Change-Id: I22dbd7cd43d94763ac941f0c3871dc7e4ea8db8d
-
- Jun 15, 2023
-
-
Nikita Ioffe authored
This mount point is required for apexd, which uses libselinux to adjust label of the compressed APEXes that are decompressed as part of the postinstall hook. Bug: 284277137 Test: m dist Test: system/update_engine/scripts/update_device.py out/dist/ota.zip Change-Id: Ia1a65a4e69b27351941a290210004a93470ae87f Merged-In: Ia1a65a4e69b27351941a290210004a93470ae87f (cherry picked from commit 56fd71b0)
-
John Reck authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23690614 Change-Id: Ia662e7eff560ee3974a2941acd9afcac7b5e89f8 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
John Reck authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/23690614 Change-Id: I24e73f6d21179922490bd797d7ef8c9ccf26883b Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Nolan Scobie authored
Bug: 257123981 Test: presubmit Change-Id: I064786d22726663216d9bf3cfd3b0c866c9b62de
-
Nolan Scobie authored
Bug: 277347398 Bug: 257123981 Test: libgui_test via TEST_MAPPING with selective exclusions in child patch Change-Id: I7bd56f6006378e4800ab36e4b7c5151017693921
-
John Reck authored
-
Arpit Singh authored
RawAbsoluteAxisInfo remains unchanged during lifetime of a device we can store this value in cache. This will minimise dependency on enable/disable and allow us to make read failures fatal. Test: m checkinput && atest inputflinger_tests Bug: 285478143 Change-Id: Ied062566f58938601a65d9e643e7acbcabd3c665
-
Vishnu Nair authored
-