Commits · f151262626f1c08a104cc35d9864493ea8a72dec · halogenOS / android_frameworks_native

Sep 23, 2024

Merge "Error fix from enabling Clang thread-safety checks in Cuttlefish" into main · f1512626
Treehugger Robot authored 5 months ago

f1512626

Error fix from enabling Clang thread-safety checks in Cuttlefish · 85e62f11

Liz Prucka authored 5 months ago

Parent bug: b/353324127. Enabling `thread-safety-reference-return`
to allow developers to utilize Clang thread safety guardrails
(GUARDED_BY, REQUIRES, EXCLUDES).

Added NO_THREAD_SAFETY_ANALYSIS annotations to violating functions.
If this is not desired, please respond with concerns
or preferred fix.

Bug: 354740314
Flag: TEST_ONLY
Test: m out/soong/.intermediates/frameworks/native/services/surfaceflinger/tests/unittests/libsurfaceflinger_unittest/android_x86_silvermont/obj/frameworks/native/services/surfaceflinger/tests/unittests/CommitTest.o
Change-Id: I9be1254c3e2685b0aa950b314c581824f40ce26c

85e62f11

Add a flag header file with dependencies. · 432e447d

Carlos Martinez Romero authored 6 months ago

Test: Built and ran
Bug: 342199002
Flag: EXEMPT no-op change
Change-Id: I0c0e0284db8c45eb5af1e9a490a5a91f63a76946

432e447d

Merge "Add more cachable service to libbinder cache" into main am: am: · 1dc3b463

Parth Sane authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3271892

Change-Id: I6291c0ebf0a2391c10bb380560978fcc429d0193
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

1dc3b463

Merge "Add more cachable service to libbinder cache" into main am: · 32e4866b

Parth Sane authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3271892

Change-Id: I4e5f0f3b2e672da721d87bce2714c035f940bde5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

32e4866b

Merge "Add more cachable service to libbinder cache" into main · f5edc0b2
Parth Sane authored 5 months ago

f5edc0b2

Merge "Read from aflags in dumpstate" into main am: am: · bff90ed1

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3264077

Change-Id: I5cebaf2323e08593ba02554fa57785407875dd73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

bff90ed1

Merge changes I463f4a0c,I09748008,I0c008ea8 into main · 6faafea0

Melody Hsu authored 5 months ago

* changes:
  [legacy layer cleanup] Misc dead code in Layer
  [legacy layer cleanup] Transaction methods
  [legacy layer cleanup] Crop and transform methods

6faafea0

Merge "Read from aflags in dumpstate" into main am: · 34b1ae06

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3264077

Change-Id: I9b05b2833eb863891d87829326e78f3bdd51d520
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

34b1ae06

Merge "Generate HOVER_EXIT if touchable region changes" into main · 0b950098
Treehugger Robot authored 5 months ago

0b950098
Merge "Read from aflags in dumpstate" into main · daa348c0
Treehugger Robot authored 5 months ago

daa348c0
Merge "Revert "Add some tracing for release fences"" into main · cd0ed9f0
Alec Mouri authored 5 months ago

cd0ed9f0

Merge "Remove gaillard@ from debugstore OWNERS" into main am: am: · 3cc94148

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3276511

Change-Id: I3f3c49ea3a4880ea5d9ac39af915dca4b3950c52
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

3cc94148

Merge "Remove gaillard@ from debugstore OWNERS" into main am: · 3cab503f

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3276511

Change-Id: I841dbfd2472c8f3fb7b9069737b52fd6d124c859
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

3cab503f

Merge "Remove gaillard@ from debugstore OWNERS" into main · 754febbb
Treehugger Robot authored 5 months ago

754febbb

Revert "Add some tracing for release fences" · 454c5524

Alec Mouri authored 5 months ago

This reverts commit 3118f969.

Reason for revert: b/368514217

Change-Id: Id69a0bd8850d2b6c093f7ce78817cdf5705215b1

454c5524

Remove gaillard@ from debugstore OWNERS · 775d0859
Olivier Gaillard authored 5 months ago
```
Change-Id: Ia21c7bb1296dd03af0e08f614a597d166307c69a
```
775d0859

[legacy layer cleanup] Misc dead code in Layer · 7d410016

Melody Hsu authored 5 months ago

Remove unused methods in legacy layer code.

Flag: EXEMPT flag removal
Bug: 330785038
Test: presubmit
Change-Id: I463f4a0c0a64a059babd5608ba4a4311ff6e2354

7d410016

[legacy layer cleanup] Transaction methods · 29f7d5c9

Melody Hsu authored 5 months ago

Remove unused methods in legacy layer code.

Flag: EXEMPT flag removal
Bug: 330785038
Test: presubmit
Change-Id: I097480082e95bb38d716336fa1909103c3593494

29f7d5c9

[legacy layer cleanup] Crop and transform methods · 2ee01c90

Melody Hsu authored 5 months ago

Remove unused methods in legacy layer code.

Flag: EXEMPT flag removal
Bug: 330785038
Test: presubmit
Change-Id: I0c008ea8548ef18c86bd99280f9c1f202f656cc9

2ee01c90

Sep 21, 2024

[automerger skipped] Merge "Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate +... · c420be83

Automerger Merge Worker authored 5 months ago

[automerger skipped] Merge "Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into android15-tests-dev am: 726ca290" into main am: 9f3ef6e2 -s ours am: 544abfd8 -s ours

am skip reason: Merged-In Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498 with SHA-1 12b90231 is already in history

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3275058



Change-Id: I43630610071fc56a8297e5fddbe88ac5f31cbe91
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

c420be83

[automerger skipped] Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch... · 573e5833

Rachel Lee authored 5 months ago

[automerger skipped] Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into android15-tests-dev am: 726ca290 am: c73f2d09 -s ours am: 7ab30b28 -s ours

am skip reason: Merged-In Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498 with SHA-1 12b90231 is already in history

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3275058



Change-Id: Ia1d4f87c2ef1b13402f4048839753e0aac85a43c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

573e5833

Sep 20, 2024

Merge "Move key remapping to InputReader thread(1/n)" into main · 911b48eb
Treehugger Robot authored 5 months ago

911b48eb

[automerger skipped] Merge "Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate +... · 544abfd8

Automerger Merge Worker authored 5 months ago

[automerger skipped] Merge "Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into android15-tests-dev am: 726ca290" into main am: 9f3ef6e2 -s ours

am skip reason: Merged-In Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498 with SHA-1 12b90231 is already in history

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3275058



Change-Id: Ib40cb464760594b344ef310a509309b80f545094
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

544abfd8

[automerger skipped] Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch... · 7ab30b28

Rachel Lee authored 5 months ago

[automerger skipped] Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into android15-tests-dev am: 726ca290 am: c73f2d09 -s ours

am skip reason: Merged-In Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498 with SHA-1 12b90231 is already in history

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3275058



Change-Id: If1faa5266ca122d572cee2c35887cd8c5795d8ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

7ab30b28

Merge "Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into... · 9f3ef6e2
Automerger Merge Worker authored 5 months ago
```
Merge "Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into android15-tests-dev am: 726ca290" into main
```
9f3ef6e2

Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into... · c73f2d09

Rachel Lee authored 5 months ago

Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into android15-tests-dev am: 726ca290

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3275058

Change-Id: If5e739faf7321dd4785268ed6c9dfc0d98102016
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

c73f2d09

Merge "DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR" into android15-tests-dev · 726ca290
Rachel Lee authored 5 months ago

726ca290

Merge "Remove unused include." into main am: am: · c1ff18a4

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3273618

Change-Id: I8a5de00981736c6a4041be08565e0458c65e1882
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

c1ff18a4

Merge "Remove __INTRODUCED_IN_LLNDK uses." into main am: am: · 75a0512c

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3274434

Change-Id: Ib69377c35a17e81baf7360c4034c0df9be33451d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

75a0512c

Merge "Remove unused include." into main am: · 8d500387

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3273618

Change-Id: Ie9a8b615d5690d29f4ad9357149cb9109095b1ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

8d500387

Merge "Remove __INTRODUCED_IN_LLNDK uses." into main am: · f1f0d1a1

Treehugger Robot authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3274434

Change-Id: I759e8f8889a97a996eb9e4bf5e7d677f2f3e6192
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

f1f0d1a1

Move key remapping to InputReader thread(1/n) · e5657f27

Linnan Li authored 6 months ago


Currently, the key remapping operation occurs on a non-Reader thread,
which leads to concurrent operations on the KCM object by this thread
and the Reader, causing unpredictable concurrency issues.

Here, we move this operation to the Reader thread, aligning it with
most configuration refresh methods, which can resolve the
aforementioned issues.

Additionally, we are removing the device traversal method on the Java
side because we actually intend for the key remapping operation to
apply to all full-keyboard devices. This can be fully achieved during
the InputReader refresh, so we are also removing the deviceId parameter
from the remapping interface.

There should be no behavioral changes.

Bug: 358042225
Test: atest CtsInputTestCases
Test: atest InputTests
Test: atest inputflinger_tests
Flag: EXEMPT refactor

Change-Id: I6ab802b70dc1242c796f672ac30672d10e34857f
Signed-off-by: Linnan Li <lilinnan@xiaomi.corp-partner.google.com>

e5657f27

Merge "Remove unused include." into main · 713ee06b
Treehugger Robot authored 5 months ago

713ee06b
Merge "Remove __INTRODUCED_IN_LLNDK uses." into main · 9adcb25e
Treehugger Robot authored 5 months ago

9adcb25e

Merge "Disable Clang thread-safety checks in surfaceflinger unit tests" into... · df30d2d6

Liz Prucka authored 5 months ago

Merge "Disable Clang thread-safety checks in surfaceflinger unit tests" into main am: 35798183 am: 77dd3e10

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3241307

Change-Id: I2fbaca47a7ef3882b02d68d95a7892fe843ef0ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

df30d2d6

Merge "Disable Clang thread-safety checks in surfaceflinger unit tests" into main am: · 77dd3e10

Liz Prucka authored 5 months ago

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3241307

Change-Id: I5c7ff8352ec566091619d81948460c515e26b540
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

77dd3e10

Merge "Disable Clang thread-safety checks in surfaceflinger unit tests" into main · 35798183
Liz Prucka authored 5 months ago

35798183

Disable Clang thread-safety checks in surfaceflinger unit tests · ac05bcc6

Liz Prucka authored 6 months ago

Parent bug: b/353324127. Enabling `thread-safety-reference-return`
to allow developers to utilize Clang thread safety guardrails.

The surfaceflinger unittest suite currently does not untilize mutex
locks when calling required thread-safe variables.

Example error:
frameworks/native/services/surfaceflinger/tests/unittests/TestableScheduler.h:133:52
error: returning variable 'mAttachedChoreographers' by reference
requires holding mutex 'mChoreographerLock' exclusively
[-Wthread-safety-reference-return]

Added NO_THREAD_SAFETY_ANALYSIS annotations to violating functions.

Bug: 354740314
Test: make

Change-Id: I95793ab942207660ea8e49cfd50d089e956a7ada

ac05bcc6

DO_NOT_MERGE Fix primaryRangeIsSingleRate + touch on dVRR · 5cf032c4

Rachel Lee authored 5 months ago

Disable a primaryRangeIsSingleRate section on dVRR and allow late touch
boost to trigger when no layer score. On dVRR display, the primary
physical range may be a single rate,
but late touch boost should still be able to trigger.

Bug: 353142444
Bug: 362379874
Flag: EXEMPT_bugfix
Test: atest libsurfaceflinger_unittest
Test: Twitter scrolling with and without video, with policy backdoor
Test: notification shade scrolling with policy backdoor
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7bedfbf0d7b106702a241a64a79c36205606496c)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:14e725f4ba7d1f71af2067945498a676372e0499)
Merged-In: Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498
Change-Id: Ic5b2b298fe0df357f77ef8f06b1fc0fc248e0498

5cf032c4