Ian Elliott authored 1 year ago and Simão Gomes Viana committed 1 year ago

For any instance extension that a Vulkan driver supports, if a
VkInstance is created with that extension listed multiple times, the
2nd-nth times should be ignored.  That avoids overwriting an array in
CreateInfoWrapper::FilterExtension().

CRs-Fixed: 3430007
Test: Manual testing with logcat
Bug: 288929054
Change-Id: I096a6752e0f4abef868efdb6f8b4bcbd0c0c79cd
(cherry picked from commit 3b48e157)
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

hongzuo liu authored 2 years ago and Simão Gomes Viana committed 1 year ago

Incorrectly dropped event because of pending overdue app switch when the App switch key event has arrived.

https://issuetracker.google.com/u/1/issues/255902047



Change-Id: If6dd28a8793fe6f06b6100f2cc44eafa07c0f085
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Ian Elliott authored 1 year ago and Simão Gomes Viana committed 1 year ago

Not all drivers that support the "VK_EXT_global_priority" extension
support "VK_QUEUE_GLOBAL_PRIORITY_REALTIME_EXT".  Instead of assuming
REALTIME by the existence of the extension, properly query for the
highest priority, using HIGH if available.

CRs-Fixed: 3608982
Bug: 281820575
Test: Manual testing
Change-Id: I846e829b775c7df90a44a0c97c0007cc6b44b438
(cherry picked from commit d50658fe)
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Adithya R authored 2 years ago and Simão Gomes Viana committed 1 year ago

Some vendors purposely disable brightness capability
even though the HWC completely supports it, in order
to leverage their custom brightness implementations.
One such example of this is in stock HWC of some
xiaomi devices.

Since light HAL offers lesser granual control than
HWC (since its in gamma space and not float), and
since it would be rather difficult to patch the blob
to return the right capabilities, allow forcing the
usage of HWC brightness functions via a prop:

ro.sf.force_hwc_brightness=1 (default 0).

Change-Id: I7d2fef03afbbb936572c717f769f30c9e49213e0
Signed-off-by: Adithya R <gh0strider.2k18.reborn@gmail.com>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

tangcheng authored 2 years ago and Simão Gomes Viana committed 1 year ago

While enabling #define LOG_NDEBUG 0, run camera cts test command:
run cts -m CtsCameraTestCases -t android.hardware.camera2.cts.MultiViewTest#testSharedSurfaceImageReaderSwitch
the libgui will crash due to nullptr, fix this by add nullptr
judgement when pointing to the Graphicbuffer handle
Bug: 228349805

Signed-off-by: tangcheng <tangcheng@xiaomi.com>
Change-Id: I69a84bdb5208b16df88f5f09f45c1a93ad2afe01
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Mohammad Hasan Keramat J <ikeramat@protonmail.com>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Rajat Yadav authored 3 years ago and Simão Gomes Viana committed 1 year ago

Reset validateWasSkipped variable in the PostCommit phase of
draw cycle with Skip Validate.

CRs-Fixed: 3035058
Change-Id: I85348dd0c80bd1258ac630b000bd694b34af6e12
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Rheygine Medel authored 2 years ago and Simão Gomes Viana committed 1 year ago

CRs-Fixed: 3215802
Change-Id: I92613a41a0cb9da2ad44e8a2ac803a5533ea6495
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Ray Zhang authored 2 years ago and Simão Gomes Viana committed 1 year ago

In streaming video case, video decoder needs to change buffer
color space dynamically according to video stream real-time
parameters.

CRs-Fixed: 3155775
Change-Id: I21590ee41708f5cb1ed45cb5a7f5c00f1c129bb0
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Danny Lin authored 3 years ago and Simão Gomes Viana committed 1 year ago

Unlinking death recipients (from linkToDeath) is a normal part of Binder
operation, and doing it when a BpBinder's refcount has reached 0 is not
much different.

This log message is constantly spamming when swiping as part of a back
navigation gesture:

04-05 22:29:41.402   655  3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor>
04-05 22:29:41.413   655  3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor>
04-05 22:29:41.424   655  3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor>
04-05 22:29:41.435   655   681 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor>
04-05 22:29:41.447   655  3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor>

Logging is relatively expensive on Android and the log spam isn't
useful, so suppress this log message by setting it to the verbose log
level.

Change-Id: I774d0c59ca6f70a4e2ed33b9fac3fb5b86d8ff0a
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Adithya R authored 2 years ago and Simão Gomes Viana committed 1 year ago

Layer dataspace is initialized as unknown by default, unless
overriden by the buffer source. We don't require expensive
rendering for color conversion when the dataspace is unknown.

Change-Id: I079c520f63a65c77ba3162664656e607eafff991
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Simão Gomes Viana authored 2 years ago and Simão Gomes Viana committed 1 year ago

Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Simao Gomes Viana authored 5 years ago and Simão Gomes Viana committed 1 year ago

Change-Id: Icdfd3512a79d9935d3fdb611c96dc8fd91a5e1c5
Signed-off-by: DennySPB <dennyspb@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Simao Gomes Viana <simao@halogenos.org>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

dianlujitao authored 4 years ago and Simão Gomes Viana committed 1 year ago

Author: Bruno Martins <bgcngm@gmail.com>
Date:   Wed Oct 14 23:45:14 2020 +0100
Edit:   Adapt to new lineage soong config

Change-Id: Ic0f314f4053628667a921951f610839f36a5079c
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Rheygine Medel authored 2 years ago and Simão Gomes Viana committed 1 year ago

Change-Id: Iecd2be3eb8775855d82763f069a38bb70fe53d4e
CRs-Fixed: 3229968
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Rheygine Medel authored 2 years ago and Simão Gomes Viana committed 1 year ago

Currently, the properties are used as follows:
1. debug.sf.enable_hwc_vds - allows IDs to be generated for VDs
2. vendor.display.vds_allow_hwc - allows WFD to use HWC path

With this change, HWC path is enabled for WFD with only the vendor
property set. All other virtual displays require both of the
properties enabled.

Change-Id: Iab2c8d15d2c1cf24be0d371af8892c346634507f
CRs-Fixed: 3204941
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Michael Bestas authored 3 years ago and Simão Gomes Viana committed 1 year ago

* These changes are part of CAF AOSP merge commits

Change-Id: I390f874347d259fca4429c19711be6c85b104090
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Rajat Yadav authored 3 years ago and Simão Gomes Viana committed 1 year ago

Allow HWC based virtual display only for wifi display

CRs-Fixed: 2984439

Change-Id: Ifbb094a2a0101171b475bd5a60660a3599dce5ff
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Chris Gross authored 4 years ago and Simão Gomes Viana committed 1 year ago

Bug: 169788930
Change-Id: Ic50f5675d0cd48f84fb9ff14221355741dc52129
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Ramakant Singh authored 4 years ago and Simão Gomes Viana committed 1 year ago

1. SurfaceFlinger: Fix virtual display related issues. 1) Validate
output
buffer usage bit appropriately Validate output buffer usage bit only
against GRALLOC_USAGE_HW_COMPOSER to differentiate GLES only
conposition
and HWC/MIXED composition. 2) Exclude video encoder usage for
scratch
buffer Sink and Scratch buffers in VDS are using same usage
flags. This
causes video encoder flag to be set for scratch buffers
Also. Exclude
video encoder flag from scratch buffer usage flags as
scratch buffers
are used only as write back input and not video
encoder input.

2. sf: Allow VDS to use HWC -- Preserve VDS layer
pixel format based on
GRALLOC flags. -- skip color layer for vds

3. sf: Add secure content support for VDS

4. sf: Enable GPU comp. for non-primary displays
Ensure that "Return
status" of dequeueBuffer() complies with API
	requirements. Client relies
on this status to call requestBuffer()
	upon reallocation.

5. sf: Enable UBWC on virtual display scratch buffer Set
	GRALLOC_USAGE_HW_FB usage flag on virtual display Scratch
	buffer to
	enable UBWC.

Change-Id: Ia49a175372ca187a295531e18f8e84dc22a19486
CRs-Fixed: 2656027
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Adithya R authored 2 years ago and Simão Gomes Viana committed 1 year ago

Taken from CLO (QSSI 13). Some Qualcomm devices can still
benefit from disabling backpressure propagation by setting:

debug.sf.disable_backpressure=1

[adi8900]: Adapted to Android U

Change-Id: I2346a1b314666706e1299b295f13b2cef6e00b4d
Signed-off-by: adi8900 <adrianszymanski242@gmail.com>
Signed-off-by: Simão Gomes Viana <devel@superboring.dev>

Rajat Yadav authored 3 years ago and Simão Gomes Viana committed 1 year ago

CRs-Fixed: 3013293

Change-Id: Idfafcd6aa718054ff749bd5d1c7eb2630be0f109

daniml3 authored 3 years ago and Simão Gomes Viana committed 1 year ago

The FOD layers should be always composed by the device to set the
custom zpos bits to the kernel. By default all layers are set to
device composition and the proprietary libsdmextension.so moves
some to client composition. Unfortunately that also affects the
Udfps touched layer. After this commit the layer below the Udfps
touched layer is forced to be client composition. For unknown
reasons libsdmextension will not change the Udfps touched layer
to client composition anymore.

tests:
- Run 'adb shell dumpsys SurfaceFlinger' and ensure that the Udfps
  touched layer is composed by the device
- Ensure that the Udfps touched layer correctly sets the zpos bits
  on the kernel while / after using WFD

Signed-off-by: daniml3 <danimoral1001@gmail.com>
Signed-off-by: Arian <arian.kulmer@web.de>
Change-Id: I8aeb98d18557ad4e971eaba74700ceb3058273ab

Pierre-Hugues Husson authored 4 years ago and Simão Gomes Viana committed 1 year ago

 * Supports changed z Udfps order
 * Supports changed Udfps usage bits

TheScarastic: Adapt to extension lib and support 12 BiometricPrompt
ArianK16a: Adapt layer name to UdfpsControllerOverlay for Android 13
    and only compare the prefix. Drop the BufferQueueLayer change
    because it seems unnecessary.

Co-authored-by: TheScarastic <warabhishek@gmail.com>
Change-Id: Id95aa73e06b4223a6b4f05c69fa2fc494f9a97b1

Kevin F. Haggerty authored 3 years ago and Simão Gomes Viana committed 1 year ago

* Change I7f4174581e24e361577640b9263514a168ed482d implemented
  validation of the buffer description info prior to creating
  the descriptor. Some of our legacy devices need to whitelist
  additional usage bits to support various functionality.

libui: Extend adb95ae to Gralloc3
libui: Extend adb95ae to Gralloc4

This commit squashes:
  libui: Convert lineage product variables to soong config variables
  Change-Id: Ib687c966d4eafcc1128611b95ebed00fd0a8bfaf

Change-Id: Ie369e78f78e9ac0b18ab3dfea520d4f123005d92

Vinay Verma authored 6 years ago and Simão Gomes Viana committed 1 year ago

libstagefright_omx library need to be extended to vendor which
is depenednet on libgui which is a vndk_private lib.
Creating vendor version so that libstagefright_omx_ext can link
to libgui_vendor.

 Conflicts:
	libs/gui/Android.bp

CRs-Fixed: 2258968
Change-Id: I777eebffc405c8bb74aab270e9f272c806501458
Signed-off-by: Volodymyr Zhdanov <wight554@gmail.com>
Signed-off-by: SamarV-121 <samarvispute121@pm.me>

Change-Id: Ic42599276b00c054165117b022054313e01d8d28

This change improves the performance of the WindowInfosListenerInvoker work done on SurfaceFlinger's background executor thread. The primary optimization made is not sending a WindowInfosReportedListener with every call to WindowInfosListener.onWindowInfosChanged. Instead, we send a new interface, WindowInfosPublisher, and a unique listener id to listeners when they're added.  Listeners call WindowInfosPublisher.ackWindowInfosReceived with their id after processing each update.

From traces taken during development, the new code is a major improvement, taking about 15% of the time spent previously on SurfaceFlinger's background thread for sending window infos. Performance with this change seems roughly in line with the performance in T.

Bug: 290377931
Test: atest WindowInfosListenerTest
Test: atest WindowInfosListenerInvokerTest
Test: manually killing system server and checking valid state on restart
(cherry picked from commit acd2258a)
(cherry picked from commit e8a7ab25)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:82f3463d449eb13e28c5dbffeee16e10721c71d2)
Merged-In: Ib39ba935727df0bc1ab4030bcfe8301de7e64805
Change-Id: Ib39ba935727df0bc1ab4030bcfe8301de7e64805

Change-Id: I3f59bd24615d8ae8ce5ebec8c257cf3eb77cf25a

This adds a unit test and fix for the bug reported by libfuzzer.
Changes made:
 * Expose GPUService as testable code.
 * Update main_gpuservice.cpp to use the new GpuService now located at
   gpuservice/GpuService.h
 * Make initializer threads members of GpuService
 * Join the threads in destructor to prevent heap-use-after-free.
 * Add unit test that waits 3 seconds after deallocation to ensure no
   wrong access is made.

Bug: 282919145
Test: Added unit test and ran on device with ASAN
(cherry picked from commit 3c00cbc0)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a8186037a730699b53e49de7241280c7532e5fc4)
Merged-In: I4d1d2d4658b575bf2c8f425f91f68f03114ad029
Change-Id: I4d1d2d4658b575bf2c8f425f91f68f03114ad029

Change-Id: I0c7836905fa7d0e6ec84c60fbbb205fee50f6177

LOG(FATAL) crashes the device, which is very severe for the user.

The accessibility hover event stream has consistency issues that we
are actively fixing, but these fixes have not yet had time to soak.
Instead of cherrypicking the fix, instead we can demote the severity
of the log so that errors do not crash the device.

Bug: 286037469
Test: atest InputDispatcherTest#InvalidA11yHoverStreamDoesNotCrash
Test: Use talkback, repeatedly enter touch exploration while also
      tapping with another finger. Eventually observe the failure
      message which is now an ERROR instead of crashing the device
      with a FATAL.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2f99cdb9150461c6b77c29b31cbf5792a9303c95)
Merged-In: Iceea086345691cdad8ca5e092629de094d666de1
Change-Id: Iceea086345691cdad8ca5e092629de094d666de1

Merge cherrypicks of ['googleplex-android-review.googlesource.com/24168505', 'googleplex-android-review.googlesource.com/24193668'] into udc-release.

Change-Id: I04ad95aff4326de414724d438459bd5d6f7ccd63

Some layers are extraordinarily large. In the particular case we've
found, the layer does not have any content, but even if it did, content
outside the display would not impact the blur. So limit the size of the
rectangle we use for blurring, which in turn limits the size of the
buffers we allocate to compute the blur.

Use the canvas' existing clip, which has already been adjusted to the
size of the display.

Bug: 283427479
Bug: 292539958
Test: manual (logcat)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:763e450b7c5fa6ad1ed35cabb96fdb87467d00c2)
Merged-In: I17e646cce0dca02f4e6a18032ecd1e9120fcf880
Change-Id: I17e646cce0dca02f4e6a18032ecd1e9120fcf880

Bug: 292284515
Test: Builds
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9438cea895cc19d5d80e1af4b18b437d1bfe8277)
Merged-In: Ifd263d93e1c1b8bb8043712283e38e4434079f85
Change-Id: Ifd263d93e1c1b8bb8043712283e38e4434079f85

Change-Id: If20455e569194ae05609258a737cd8a069455e76

Some HAL implementations can't support setLayerBuffer multiple times to
clear the per-layer buffer caches. Therefore, default this behavior to
disabled, and allow HALs to explcitily enable this behavior to obtain
the necessary memory savings.

Test: play videos with both true and false on both HIDL and AIDL
Bug: 285561686
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:f70d9c4528888134e16003470b76dd1e81b8631d)
Merged-In: I928cef25e35cfc5337db4ceb8581bf5926b4fbe3
Change-Id: I928cef25e35cfc5337db4ceb8581bf5926b4fbe3

Change-Id: I456162e87dfe31eef76e335f0f52b47a94732f7f