- Sep 20, 2024
-
-
libwfdnative compiled for 14 QPR1 depends on this symbol. Change-Id: I7bc5ee3fb7760a9f470023cd0daa215b2e194dc1 Signed-off-by:
Simão Gomes Viana <devel@superboring.dev>
-
- Sep 19, 2024
-
-
Change-Id: I90daada0d887008d56e84ce29b3f0b011a298698 Signed-off-by:
Corinna Vinschen <xda@vinschen.de> Signed-off-by:
Simão Gomes Viana <devel@superboring.dev>
-
- Jun 11, 2024
-
-
Dominik Laskowski authored
Bug: 185536303 Flag: DOCS_ONLY Test: N/A Change-Id: I96246cacb63dec70caa732064fd5159d596d4e25
-
Dominik Laskowski authored
Like FTL_TRY, FTL_EXPECT unwraps T for Expected<T, E> or does an early out on error, but it bails out with E instead of Expected<T, E>. Fix a line in the Expected.Try test to call the intended helper. Bug: 185536303 Test: ftl_test Change-Id: I238ae2978ff606c5c035e9791496c2b20729ca7f
-
- Jun 10, 2024
-
-
Prabir Pradhan authored
Remove PointerCoords::transform(), which is a duplicate of MotionEvent::calculateTranformedCoords(). Bug: 342349872 Test: atest inputflinger_tests libinput_tests Change-Id: I7610a0475a16e9964817f63efa67b291cb7aaf0a
-
Prabir Pradhan authored
We have three cases for handling AXIS_ORIENTATION: 1. Orientation is not supported by the input device, so the value for AXIS_ORIENTATION should always be 0, regardless of display rotation. 2. Orientation is supported, but a "direction" is not specified, like for touchscreens and touchpads. The orientation must be in the range [-pi/2, pi/2] for all display rotations. 3. Orientation is fully supported, and the value is in the range [-pi, pi] for all display rotations. It is insufficient to rely on whether or not the PointerCoords has the bit for AXIS_ORIENTATION set to determine whether the event has a valid orientation. This is because we always skip setting values of 0 for any axis in PointerCoords to save space during serialization. To support these three cases, we introduce two new MotionEvent private flags. These are flags that are not exposed to Java and to the public APIs. Bug: 263310669 Test: atest TouchScreenTest libinput_tests inputflinger_tests Change-Id: Iaa38afe35b00de74fbc5eefce25191bea52c2ea6
-
- Jun 07, 2024
-
-
Vaibhav Devmurari authored
DD: go/project-imposter-android This CL includes: - Rust interface setup Next CL to include: - Basic categorization into alphabetic and non-alphabetic - Updating categorization based on key presses Test: atest --host libinput_rust_test Test: atest inputflinger_tests Bug: 263559234 Flag: com.android.input.flags.enable_keyboard_classifier_rust_impl Change-Id: I52773be992ddd8efaa9546e0af8b0a78515d931c
-
- May 23, 2024
-
-
Frederick Mayle authored
This commit explicitly marks symbols in the code with default visibility if they should be part of the libbinder ABI. Later, we'll set the default symbol visibility to hidden and so any symbols not explicitly marked as exported will be hidden. We are still overexporting symbols a bit. When `LIBBINDER_EXPORTED` is applied to a class, it exports all of that class's symbols. I've tried to only export class members, but in a few cases it didn't seem worth the trouble, e.g. where all the members need to be exported. Additionally, we are exporting some symbols only needed by binder test binaries. Since those tests run against the standard libbinder.so, we need to include the symbols as part of the ABI. On aarch64, this reduces the size of libbinder_on_trusty_mock.so by 10.7% and libbinder.so by 7.5%, primarily in the .text, .dynstr, and .dynsym sections (but none of this takes effect until we actually enabled it in a later commit). Bug: 338458975 Test: TH Change-Id: Idc348c2b12124a8bbcebeea49920267a995367b6
-
- May 14, 2024
-
-
Dominik Laskowski authored
Optional<T>::ok_or maps to Expected<T, E> where nullopt becomes E. FTL_TRY unwraps T for Expected<T, E> or does an early out on error. Bug: 185536303 Test: ftl_test Change-Id: Ia03f7e3d8773878db1c493b62772ab2c2b7a4fed
-
Dominik Laskowski authored
- Silence warning about signedness change. - Disable copying to prevent stray end_ pointer. Bug: 185536303 Test: Build Change-Id: Ief31910bd51e9582a576ace554a5f7bafe46bf02
-
Siarhei Vishniakou authored
These will eventually replace the existing definitions as follows: ADISPLAY_ID_NONE -->> LogicalDisplayId::INVALID ADISPLAY_ID_DEFAULT -->> LogicalDisplayId::DEFAULT We are keeping the old definitions for now, to reduce the merge conflicts. These will be removed in subsequent CLs, after the frameworks/base and other repository patches go in. The constant "NONE" was renamed to "INVALID" to make it consistent with the Java definitions. Bug: 339106983 Test: m checkinput Change-Id: I0274be345159c85cb51fcea743d8acd3d298cd07
-
- May 11, 2024
-
-
Siarhei Vishniakou authored
The downstream branches now know about Parcel and binder, so in some places, these #ifdef statements are not needed. This CL should help reduce the divergence with downstream efforts. See the merge conflict resolution CL as an example: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/native/+/27201796/-2..3 Bug: 309829647 Test: presubmit Change-Id: Iec17cface5069ca79a565c205546db8ada8a07ee
-
- May 09, 2024
-
-
Linnan Li authored
Currently, we use int32_t for displayId, which is not a safe type, and it may also lead to misdefinition of types. Here, we introduce LogicalDisplayId as a strong type for displayId and move all contents of constants.h into LogicalDisplayId.h. Bug: 339106983 Test: atest inputflinger_tests Test: atest InputTests Test: m checkinput Test: m libsurfaceflinger_unittest Test: presubmit Change-Id: If44e56f69553d095af5adb59b595e4a852ab32ce Signed-off-by:
Linnan Li <lilinnan@xiaomi.corp-partner.google.com>
-
- May 08, 2024
-
-
Yi Kong authored
These functions intentionally overflows integers. The upcoming compiler update, clang-r522817, will start complaining about these overflows. Test: boot with new compiler Bug: 325934863 Change-Id: Idb3730c652ae739b73c09517665b518a79b60345
-
- May 06, 2024
-
-
Marijn Suijten authored
The surface control and transaction are barely every null in most calls, but some informational structures like HDR metadata, and the surface control when reparenting are allowed to be null. Change-Id: Ia1a456041daf8136d856a1901881b74f97b3593a Merged-In: Ia1a456041daf8136d856a1901881b74f97b3593a Test: make aosp_cf_x86_64_phone Signed-off-by:
Marijn Suijten <marijns95@gmail.com>
-
- May 03, 2024
-
-
Dan Albert authored
The messages come from a different CL in AOSP, but that CL breaks internally because this code doesn't exist in AOSP. Merging the compatibility thing first so I can land the rest in AOSP. Bug: None Test: None Change-Id: I906c6ea7bd6d891aba9e185756131ac5b34f3c3d
-
- May 02, 2024
-
-
Dan Albert authored
"Unrecoverable internal errors" here means that ALOOPER_POLL_ERROR will be returned if the internal epoll_wait call fails with something other than EINTR. I could say that explicitly, but I think the important info for the caller is "you're doomed, just abort". Bug: None Test: None Change-Id: I869f29122500ee8c71390cae1c28108a63088a77
-
Dan Albert authored
This (hopefully) explains all the bits that confused me when I tried to use these APIs for the first time. The existing docs leaned a lot on developers already understanding the Java API, and even the Java API docs didn't explain how to use this portion of the API well. Bug: None Test: I am the test Change-Id: I48490112f92ef754b38daef7a4ebf6c031cc20f8
-
Dan Albert authored
They're deprecated, but still needed by most users, as the replacement is not available until API 29. Restore the docs and explain the bugs. Bug: None Test: treehugger Change-Id: I4227ce3f0ee57a73a13e394cd48373accf4a58a3
-
Dan Albert authored
Add the soon-to-be-required removal message for ALooper_pollAll, and expand the docs for both ALooper_pollAll and ALooper_pollOnce to make the reason for removal clear, and to explain the fix callers should apply. Bug: https://github.com/android/ndk/issues/2014 Test: treehugger Change-Id: I020a280346d1ff9f5fcbec4c153dee8319cdf539
-
Dan Albert authored
Bug: None Test: treehugger Change-Id: I3a52883fba0e31f05e50cd51193bbb306418b18a
-
Lloyd Pique authored
* Disallow NonNull<bool> by checking for nullptr, instead of false. * Add an "operator bool()" to work like other smart pointers. * Add [[nodiscard]] where it makes sense. * Implement the full set of comparison operations, and allow comparisons between NonNull<P> and another type Q. This allows the use of NonNull<P> in sorted containers like std::set, and allows easier lookup via unwrapped pointers. * Specialize std::hash for NonNull. This allows the use of NonNull<P> in hashed containers like std::unordered_set. Test: atest ftl_test Bug: 185536303 Change-Id: Ib1090e393ea5f5641be2cd9c61011049039ea615
-
Lloyd Pique authored
ftl::contains(container, value) returns true if the container contains the value. It's implemented in terms of std::find(), so has the same runtime complexity. It is otherwise a simplified version of the C++23 std::ranges::contains, which has some additional options, and can be deprecated once C++23 is the minimal supported version. Test: atest ftl_test Bug: 185536303 Change-Id: I98aefe7cf6645ac3a20fddfe0657fa6822d669de
-
- May 01, 2024
-
-
Siarhei Vishniakou authored
This is already useful in several places, and it's going to be also useful in the future when InputConsumer is refactored. So let's move it to include/input. Bug: 311142655 Test: m inputflinger_blocking_queue_fuzzer (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3782af62ea590e8945f2175a90aa2b6f4995814d) Merged-In: Idfc492c6bfc3cccab7e0b0d12b21a41a954cc44b Change-Id: Ie662961b77d331cd62b529bae0fd66e56a69bd19
-
Siarhei Vishniakou authored
To ensure that the future updates are consistent across java, cpp, and rust, we move all of motion event flags to aidl. That will be the source of truth for those constants. That still doesn't ensure that in the future updates, we forget to add these to all the languages, but at least now it will be much easier to do so. Bug: 309829647 Test: m sync Change-Id: Ibb92c0c2b2da3b07eac3886c6fd652a295037099
-
- Apr 29, 2024
-
-
Alan Ding authored
Extends stable hash from libui by increasing maximum string length supported from 16 to 64 bytes (CityHash64 v1.0.1 - please see http://code.google.com/p/cityhash/). Bug: 185536303 Bug: 194863377 Test: ftl_test Test: Compare with 64-bit std::hash<std::string_view> Change-Id: Ib123d0690a0d2150aa51c91526784dcf77a65d46
-
- Apr 24, 2024
-
-
Harry Cutts authored
These occur when an enum value is formatted as an integer without a cast. In all these cases the debug logs are nicer if we use the actual name of the enum value, so wrap them all in ftl::enum_string calls. Bug: 245989146 Test: Check there are no -Wformat warnings in the output of $ m checkinput Change-Id: I26333123e9fb445f1640c5e73757ddf4ad2d6e98
-
- Apr 23, 2024
-
-
Matt Buckley authored
Adds a hidden method for the creation of special "internal" hint sessions with extra metadata, and plumbs hwui to use it Bug: 330553312 Test: atest PerformanceHintNativeTestCases Test: hwui unit tests Change-Id: I2e7eb8fe010b7314c3e91ec2d11ac1910c234262
-
Linnan Li authored
We currently display the pointer for all devices that support displaying it, but there are actually some devices that are disabled and shouldn't actually have it displayed for them, here's an implementation for that. This is done by adding an enabled state to the InputDeviceInfo to determine its disabled status. Bug: 335795596 Test: atest inputflinger_tests Signed-off-by:
Linnan Li <lilinnan@xiaomi.corp-partner.google.com> (cherry picked from https://partner-android-review.googlesource.com/q/commit:d7c5c6d376f5eae7cbb7cce5ea12f2ba420d87ab) Merged-In: Ibdad9f8424a29d83412866eace0ef96026fb270a Change-Id: Ibdad9f8424a29d83412866eace0ef96026fb270a
-
- Apr 19, 2024
-
-
Marijn Suijten authored
The surface control and transaction are barely every null in most calls, but some informational structures like HDR metadata, and the surface control when reparenting are allowed to be null. Change-Id: Ia1a456041daf8136d856a1901881b74f97b3593a Test: make aosp_cf_x86_64_phone Signed-off-by:
Marijn Suijten <marijns95@gmail.com>
-
- Apr 16, 2024
-
-
DingYong authored
Change-Id: I6e18c9d99d562aec112fc8ecb3d4e916285368c6 Test: Built
-
- Apr 12, 2024
-
-
Xiang Wang authored
This keeps it consistent with the SDK doc. Bug: 332253611 Test: n/a Change-Id: I988f9be7eb37ac1d57edd403dc30f0e17e2b2db3
-
- Apr 02, 2024
-
-
Marijn Suijten authored
By declaring the ABI of `enum` types, the `enum` type can now be used in place of a raw and untyped integer in function parameters and structure fields, self-documenting what the possible values are. Test: treehugger Change-Id: I6b9cf8b36b16e23c0e992f8155452bd194e6e1ad Signed-off-by:
Marijn Suijten <marijns95@gmail.com>
-
Dan Albert authored
Bug: https://github.com/android/ndk/issues/1920 Test: treehugger Change-Id: Ib8296e7b9c86809d16fbde0787d016095a189387
-
- Mar 30, 2024
-
-
Derek Wu authored
This will change MotionPredictor::predict() outputs once enable_prediction_pruning_via_jerk_thresholding is enabled. Test: atest libinput_tests --host with local flag override to enable enable_prediction_pruning_via_jerk_thresholding. Test: atest CtsInputTestCases Test: atest MotionPredictorBenchmark MotionPredictorTest Bug: 266747654 Change-Id: I11eb1972246468a1f3824656f5ac57e01e0359cd
-
- Mar 29, 2024
-
-
Siarhei Vishniakou authored
This will help understand when it's created and destroyed. This also helps disambiguate between multiple InputConsumers in the same process. Test procedure: 1. Add "system tracing" to quick settings from developer options (enable the quick settings tile for system tracing) 2. Start system tracing via UI of quick settings 3. Open all apps and do some swipes 4. Click "stop tracing" 5. Pull the logs to the device `adb pull /data/local/traces/ ~/trace` 6. Go to https://ui.perfetto.dev/ 7. Click "open trace file" and navigate to the local file 8. In the trace, open the process of interest. In this case, it's the launcher process 9. Scroll down to "InputConsumer processing" 10. The "cookie" field of each entry is the sequence number of this event (but not the event id). Bug: 311142655 Test: perfetto test procedure described above Change-Id: If8cdadd3604e8e3ab24c45a5ccf4ea9ffa9fee4a
-
- Mar 27, 2024
-
-
Derek Wu authored
This is a no-op Test: atest libinput_tests Bug: 266747654 Change-Id: I0f67a1d8ea59a6851afa6f523b6e00b2281745d0
-
- Mar 26, 2024
-
-
Yuichiro Hanada authored
to be shared between Java and C++. The values of PointerIconStyle in Input.h and the constants in PointerIcon.java are manually synced now. This change introduces an AIDL file which can be used by both. Bug: 235023317, 330827347 Test: presubmit Change-Id: I01f31868e7c13270047673d97035783deaf0a7f6
-
- Mar 21, 2024
-
-
Linnan Li authored
Because of the existence of extra spaces, the owner of keycodes.h is not configured as expected. We should delete this extra spaces. Bug: none Test: After merging, check whether the owner of keycodes.h includes all users under INPUT_OWNER Change-Id: I634c49f53a4633bdee3cdefbf0debae4dff90a47
-
- Mar 20, 2024
-
-
Chavi Weingarten authored
Test: Builds Bug: 330375394 Change-Id: I54a51e3f78d5c44067369d3fce3a61fd18a4157b
-